You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "valkum (via GitHub)" <gi...@apache.org> on 2026/05/21 15:19:55 UTC

[PR] feat: add reqwest-rustls-no-provider-tls feature [opendal]

valkum opened a new pull request, #7582:
URL: https://github.com/apache/opendal/pull/7582

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part of #7571.
   
   # Rationale for this change
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   https://github.com/apache/opendal/pull/7365 placed a hard dependency on `aws-lc-rs` by enabling the `reqwest/rustls` feature.
   
   This prevents downstream users from providing their own crypto provider such as `ring`.
   
   
   # What changes are included in this PR?
   A new feature is added `reqwest-rustls-no-provider-tls` which will forward to `reqwest` and enables `reqwests`'s `rustls-no-provider` feature.
   
   The cargo tree output after applying this looks like:
   ```
   # cargo tree -p opendal --no-default-features --features services-gcs --edges normal,build -i aws-lc-rs
   aws-lc-rs v1.16.3
   └── jsonwebtoken v10.3.0
       └── reqsign-google v3.0.0
           └── opendal-service-gcs v0.56.0 (/Users/valkum/git/opendal/core/services/gcs)
               └── opendal v0.56.0 (/Users/valkum/git/opendal/core)
   ```
   There is https://github.com/apache/opendal-reqsign/issues/754 to remove `aws-lc-rs` from `reqsign-google`
   
   Other ideas floating around in #7571 are disabling any default HTTP client. This PR does not try to implement that.
   
   
   # Are there any user-facing changes?
   The current `reqwest-rustls` feature and the default feature set are unchanged.
   
   # AI Usage Statement
   
   <!--
   If you are using AI tools to build this PR, please include a statement specifying the tool and models you are using.
   -->
   I used Claude Code Opus 4.7 to review my state and impact before submitting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: add reqwest-rustls-no-provider-tls feature [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #7582:
URL: https://github.com/apache/opendal/pull/7582


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: add reqwest-rustls-no-provider-tls feature [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7582:
URL: https://github.com/apache/opendal/pull/7582#issuecomment-4510447822

   Only https://github.com/apache/opendal/actions/runs/26235284726/job/77206630747?pr=7582 need to fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: add reqwest-rustls-no-provider-tls feature [opendal]

Posted by "valkum (via GitHub)" <gi...@apache.org>.
valkum commented on PR #7582:
URL: https://github.com/apache/opendal/pull/7582#issuecomment-4510677132

   Taplo should be happy now. At least locally :) Fix is rebased into the commit to keep the history clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org