You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2003/06/01 01:42:30 UTC
cvs commit: jakarta-james/src/java/org/apache/james/mailrepository JDBCMailRepository.java
noel 2003/05/31 16:42:30
Modified: src/java/org/apache/james/mailrepository Tag: branch_2_1_fcs
JDBCMailRepository.java
Log:
Allow initialization String members that are never again used to be garbage collected.
Revision Changes Path
No revision
No revision
1.30.4.6 +6 -7 jakarta-james/src/java/org/apache/james/mailrepository/JDBCMailRepository.java
Index: JDBCMailRepository.java
===================================================================
RCS file: /home/cvs/jakarta-james/src/java/org/apache/james/mailrepository/JDBCMailRepository.java,v
retrieving revision 1.30.4.5
retrieving revision 1.30.4.6
diff -u -r1.30.4.5 -r1.30.4.6
--- JDBCMailRepository.java 7 May 2003 03:12:02 -0000 1.30.4.5
+++ JDBCMailRepository.java 31 May 2003 23:42:29 -0000 1.30.4.6
@@ -107,8 +107,6 @@
*
* <p>Requires a logger called MailRepository.
*
- * @author Serge Knystautas <se...@lokitech.com>
- * @author Darrell DeBoer <dd...@bigdaz.com>
* @version 1.0.0, 24/04/1999
*/
public class JDBCMailRepository
@@ -141,7 +139,7 @@
/**
* Destination URL for the repository. See class description for more info
*/
- protected String destination;
+// protected String destination;
/**
* The table name parsed from the destination URL
@@ -156,12 +154,12 @@
/**
* The name of the filestore to be used to store mail when configured to use dbfile mode.
*/
- protected String filestore;
+// protected String filestore;
/**
* The name of the SQL configuration file to be used to configure this repository.
*/
- protected String sqlFileName;
+ private String sqlFileName;
/**
* The stream repository used in dbfile mode
@@ -230,7 +228,7 @@
getLogger().debug(this.getClass().getName() + ".configure()");
}
- destination = conf.getAttribute("destinationURL");
+ String destination = conf.getAttribute("destinationURL");
// normalize the destination, to simplify processing.
if ( ! destination.endsWith("/") ) {
destination += "/";
@@ -287,7 +285,7 @@
getLogger().debug(logBuffer.toString());
}
- filestore = conf.getChild("filestore").getValue(null);
+ String filestore = conf.getChild("filestore").getValue(null);
sqlFileName = conf.getChild("sqlFile").getValue();
if (!sqlFileName.startsWith("file://")) {
throw new ConfigurationException
@@ -364,6 +362,7 @@
File sqlFile = null;
try {
sqlFile = AvalonContextUtilities.getFile(context, sqlFileName);
+ sqlFileName = null;
} catch (Exception e) {
getLogger().fatalError(e.getMessage(), e);
throw e;
---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org