You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/15 10:53:38 UTC
[GitHub] [airflow] potiuk opened a new pull request, #23035: Google Providers (ComputeSSH) depends on paramiko.
potiuk opened a new pull request, #23035:
URL: https://github.com/apache/airflow/pull/23035
Part of: #23033
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23035: Change ComputeSSH to throw provider import error instead paramiko
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23035:
URL: https://github.com/apache/airflow/pull/23035#issuecomment-1100099817
I fixed it differently now. Together with #23037 changing import errors should fix it as we will get just info message that SSH provider is not available so the Hook won't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23035: Google Providers (ComputeSSH) depends on paramiko.
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23035:
URL: https://github.com/apache/airflow/pull/23035#issuecomment-1100058074
See - https://airflow.apache.org/docs/apache-airflow-providers-google/stable/index.html#cross-provider-package-dependencies there is an `ssh` extra. But indeed - this should be done differently.
Paramiko should be added "after" importing provider - then it will be handled as "optional feature" automatically - and we do not need to change setup.py.
Good comment @mik-laj !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #23035: Google Providers (ComputeSSH) depends on paramiko.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on PR #23035:
URL: https://github.com/apache/airflow/pull/23035#issuecomment-1100055261
It also required ssh provider
https://github.com/apache/airflow/blob/c36bcc4c06c93dce11e2306a4aff66432bffd5a5/airflow/providers/google/cloud/hooks/compute_ssh.py#L35
Should we add it to additional extras?
https://github.com/apache/airflow/blob/c36bcc4c06c93dce11e2306a4aff66432bffd5a5/airflow/providers/google/provider.yaml#L909-L913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23035: Change ComputeSSH to throw provider import error instead paramiko
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23035:
URL: https://github.com/apache/airflow/pull/23035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23035: Google Providers (ComputeSSH) depends on paramiko.
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23035:
URL: https://github.com/apache/airflow/pull/23035#issuecomment-1100058236
I will add some testing harness for such imports soon :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23035: Google Providers (ComputeSSH) depends on paramiko.
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23035:
URL: https://github.com/apache/airflow/pull/23035#issuecomment-1100056961
Not needed. This happens automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23035: Change ComputeSSH to throw provider import error instead paramiko
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23035:
URL: https://github.com/apache/airflow/pull/23035#issuecomment-1104709435
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org