You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Navis (JIRA)" <ji...@apache.org> on 2012/12/03 04:15:58 UTC

[jira] [Created] (HIVE-3762) Minor fix for 'tableName' in Hive.g

Navis created HIVE-3762:
---------------------------

             Summary: Minor fix for 'tableName' in Hive.g
                 Key: HIVE-3762
                 URL: https://issues.apache.org/jira/browse/HIVE-3762
             Project: Hive
          Issue Type: Improvement
          Components: Query Processor
            Reporter: Navis
            Assignee: Navis
            Priority: Trivial


Current definition for 'tableName' is "(db=Identifier DOT)? tab=Identifier". If user specifies value "default." for it, hive parser accepts "default" as table name and reserves "." for next token but it's not valid.

Really trivial but it is small needed part for improving query auto-completion (I'm doing it).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3762) Minor fix for 'tableName' in Hive.g

Posted by "Phabricator (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511104#comment-13511104 ] 

Phabricator commented on HIVE-3762:
-----------------------------------

njain has accepted the revision "HIVE-3762 [jira] Minor fix for 'tableName' in Hive.g".

REVISION DETAIL
  https://reviews.facebook.net/D7143

BRANCH
  DPAL-1939

To: JIRA, njain, navis

                
> Minor fix for 'tableName' in Hive.g
> -----------------------------------
>
>                 Key: HIVE-3762
>                 URL: https://issues.apache.org/jira/browse/HIVE-3762
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3762.D7143.1.patch
>
>
> Current definition for 'tableName' is "(db=Identifier DOT)? tab=Identifier". If user specifies value "default." for it, hive parser accepts "default" as table name and reserves "." for next token but it's not valid.
> Really trivial but it is small needed part for improving query auto-completion (I'm doing it).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3762) Minor fix for 'tableName' in Hive.g

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511103#comment-13511103 ] 

Namit Jain commented on HIVE-3762:
----------------------------------

+1
                
> Minor fix for 'tableName' in Hive.g
> -----------------------------------
>
>                 Key: HIVE-3762
>                 URL: https://issues.apache.org/jira/browse/HIVE-3762
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3762.D7143.1.patch
>
>
> Current definition for 'tableName' is "(db=Identifier DOT)? tab=Identifier". If user specifies value "default." for it, hive parser accepts "default" as table name and reserves "." for next token but it's not valid.
> Really trivial but it is small needed part for improving query auto-completion (I'm doing it).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3762) Minor fix for 'tableName' in Hive.g

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3762:
-----------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Committed. Thanks Navis
                
> Minor fix for 'tableName' in Hive.g
> -----------------------------------
>
>                 Key: HIVE-3762
>                 URL: https://issues.apache.org/jira/browse/HIVE-3762
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3762.D7143.1.patch
>
>
> Current definition for 'tableName' is "(db=Identifier DOT)? tab=Identifier". If user specifies value "default." for it, hive parser accepts "default" as table name and reserves "." for next token but it's not valid.
> Really trivial but it is small needed part for improving query auto-completion (I'm doing it).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3762) Minor fix for 'tableName' in Hive.g

Posted by "Navis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Navis updated HIVE-3762:
------------------------

    Status: Patch Available  (was: Open)
    
> Minor fix for 'tableName' in Hive.g
> -----------------------------------
>
>                 Key: HIVE-3762
>                 URL: https://issues.apache.org/jira/browse/HIVE-3762
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3762.D7143.1.patch
>
>
> Current definition for 'tableName' is "(db=Identifier DOT)? tab=Identifier". If user specifies value "default." for it, hive parser accepts "default" as table name and reserves "." for next token but it's not valid.
> Really trivial but it is small needed part for improving query auto-completion (I'm doing it).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3762) Minor fix for 'tableName' in Hive.g

Posted by "Phabricator (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-3762:
------------------------------

    Attachment: HIVE-3762.D7143.1.patch

navis requested code review of "HIVE-3762 [jira] Minor fix for 'tableName' in Hive.g".
Reviewers: JIRA

  DPAL-1939 Minor fix for tableName in Hive.g

  Current definition for 'tableName' is "(db=Identifier DOT)? tab=Identifier". If user specifies value "default." for it, hive parser accepts "default" as table name and reserves "." for next token but it's not valid.

  Really trivial but it is small needed part for improving query auto-completion (I'm doing it).

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D7143

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
  ql/src/test/results/clientnegative/invalid_tbl_name.q.out

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/16887/

To: JIRA, navis

                
> Minor fix for 'tableName' in Hive.g
> -----------------------------------
>
>                 Key: HIVE-3762
>                 URL: https://issues.apache.org/jira/browse/HIVE-3762
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-3762.D7143.1.patch
>
>
> Current definition for 'tableName' is "(db=Identifier DOT)? tab=Identifier". If user specifies value "default." for it, hive parser accepts "default" as table name and reserves "." for next token but it's not valid.
> Really trivial but it is small needed part for improving query auto-completion (I'm doing it).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira