You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "leonard2901 (via GitHub)" <gi...@apache.org> on 2023/06/01 22:23:58 UTC
[GitHub] [guacamole-client] leonard2901 opened a new pull request, #882: GUACAMOLE-1799: Add Name and Version properties to all translation files
leonard2901 opened a new pull request, #882:
URL: https://github.com/apache/guacamole-client/pull/882
Only the English and Polish translation files contain the APP.NAME and APP.VERSION properties. The values of these properties are used by the login page for example.
Currently this does not seem to be a problem because the English translation file is *somehow* always loaded before the translation file of the language that the user requested.
To not have to rely on this behavior and to prepare things for the Angular frontend I would like to include these properties in all translation files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper closed pull request #882: GUACAMOLE-1799: Add Name and Version properties to all translation files
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper closed pull request #882: GUACAMOLE-1799: Add Name and Version properties to all translation files
URL: https://github.com/apache/guacamole-client/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on pull request #882: GUACAMOLE-1799: Add Name and Version properties to all translation files
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on PR #882:
URL: https://github.com/apache/guacamole-client/pull/882#issuecomment-1572938548
Closing as the described behavior is intentional. @leonard2901, if there is a technical reason that this is impractical with Angular vs. AngularJS, please let us know. I wouldn't expect Angular to prevent us from providing the same functionality, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #882: GUACAMOLE-1799: Add Name and Version properties to all translation files
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #882:
URL: https://github.com/apache/guacamole-client/pull/882#issuecomment-1572913585
> Currently this does not seem to be a problem because the English translation file is somehow always loaded before the translation file of the language that the user requested.
This is intentional - it is done this way so that, if things are not translated into a particular language, they will still at the very least be displayed in English, rather than showing up as a very odd translation string.
> To not have to rely on this behavior and to prepare things for the Angular frontend I would like to include these properties in all translation files.
Why is relying on this behavior problematic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] leonard2901 commented on pull request #882: GUACAMOLE-1799: Add Name and Version properties to all translation files
Posted by "leonard2901 (via GitHub)" <gi...@apache.org>.
leonard2901 commented on PR #882:
URL: https://github.com/apache/guacamole-client/pull/882#issuecomment-1573245070
Using the English translations as a fallback makes sense. I did not consider that translations might be missing. Thanks for the clarification!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org