You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (Created) (JIRA)" <ji...@apache.org> on 2011/11/01 19:33:32 UTC

[jira] [Created] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Backport HBASE-4552 to 0.90 branch.
-----------------------------------

                 Key: HBASE-4718
                 URL: https://issues.apache.org/jira/browse/HBASE-4718
             Project: HBase
          Issue Type: Bug
    Affects Versions: 0.90.4
            Reporter: Jonathan Hsieh


In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.

1) provide patch but do not integrate
2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Status: Open  (was: Patch Available)
    
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150061#comment-13150061 ] 

Jonathan Hsieh commented on HBASE-4718:
---------------------------------------

Patch filed to apply since this was targeted to the 0.90 branch instead of the trunk/0.92 branch.  Attached output of selected unit tests run.


{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 146.315 sec
Running org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.407 sec

Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
{code}
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142691#comment-13142691 ] 

Jonathan Hsieh commented on HBASE-4718:
---------------------------------------

Here are the results of the relevent unit tests running tests on 0.90.x.  I'm fairly confident that only known flakies could fail on the full run, will post any anomalies.

{code}

~/proj/hbase-0.90$ mvn test -Dtest=TestLoadIncrementalHFilesSplitRecovery,TestHRegionServerBulkLoad

....

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.143 sec
Running org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 72.985 sec

Results :

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
{code}
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Status: Patch Available  (was: Open)
    
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150126#comment-13150126 ] 

Ted Yu commented on HBASE-4718:
-------------------------------

+1 on patch v4
{code}
Results :

Tests run: 700, Failures: 0, Errors: 0, Skipped: 9

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
{code}
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142828#comment-13142828 ] 

Hadoop QA commented on HBASE-4718:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502096/4718-v2.90
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/150//console

This message is automatically generated.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Attachment: hbase-4718.0.90.patch

Attached patch that is basically HBASE-4552 and the HBASE-4716 single colfam optimization.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>         Attachments: hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150078#comment-13150078 ] 

Ted Yu commented on HBASE-4718:
-------------------------------

TestLoadIncrementalHFilesSplitRecovery and TestHRegionServerBulkLoad also passed.
Running whole test suite.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Attachment: hbase-4718.v3.includes-hbase-3316.patch

Updated patch generated using --no-prefix,  uses enum from HBASE-4716, and also includes HBASE-3316.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4718:
--------------------------

    Fix Version/s: 0.90.5
     Release Note: 
HRegion.bulkLoadHFile() has been removed in 0.92 and TRUNK. It is deprecated in 0.90.5
HRegion.bulkLoadHFiles() is introduced for multi-family bulk load. 
Default value for hbase.bulkload.retries.number is 0, meaning bulk load would never give up. 
    
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Old LoadIncremtalHFiles clients will still work against this version.
                
> Backport HBASE-4552 to 0.90 branch
> ----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142799#comment-13142799 ] 

stack commented on HBASE-4718:
------------------------------

Want to reapply with --no-prefix mighty Jon?
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150046#comment-13150046 ] 

Hadoop QA commented on HBASE-4718:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503685/hbase-4718.v4.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 10 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/247//console

This message is automatically generated.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143471#comment-13143471 ] 

Ted Yu commented on HBASE-4718:
-------------------------------

Combining patch v3 with addendum for HBASE-4716 passes all tests.

@Jonathan:
Once HBASE-4740 gets resolved, let's put that with the above and make patch v4.

Thanks
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142825#comment-13142825 ] 

Ted Yu commented on HBASE-4718:
-------------------------------

Bulk-load related tests passed:
953 mt -Dtest=TestLoadIncrementalHFilesSplitRecovery
954 mt -Dtest=TestHRegionServerBulkLoad
957 mt -Dtest=TestLoadIncrementalHFiles
959 mt -Dtest=TestHFileOutputFormat
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142740#comment-13142740 ] 

Hadoop QA commented on HBASE-4718:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502059/hbase-4718.0.90.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/146//console

This message is automatically generated.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Attachment: hbase-4552.v4.patch

New version of patch that includes backport of HBASE-4552, HBASE-4716, HBASE-3316 and HBASE-4740.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143230#comment-13143230 ] 

Ted Yu commented on HBASE-4718:
-------------------------------

Since enum was removed by HBASE-4716 addendum, I think patch v2 is closer to the current TRUNK.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4718:
--------------------------

    Summary: Backport HBASE-4552 to 0.90 branch  (was: Backport HBASE-4552 to 0.90 branch.)
    
> Backport HBASE-4552 to 0.90 branch
> ----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142915#comment-13142915 ] 

Hadoop QA commented on HBASE-4718:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502112/hbase-4718.v3.includes-hbase-3316.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 10 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/153//console

This message is automatically generated.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142658#comment-13142658 ] 

Jonathan Hsieh commented on HBASE-4718:
---------------------------------------

I have verified that stock 0.90.4's non-atomic bulk import still works against a standalone cluster running 0.90.5-snapshot including the HBASE-4718 patch (combined backport of HBASE-4552/HBASE-4716) and the HBASE-3316 patch (separate but trivial backport)
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143352#comment-13143352 ] 

Ted Yu commented on HBASE-4718:
-------------------------------

I got the following when running test suite with patch v2:
{code}
testLogRollOnPipelineRestart(org.apache.hadoop.hbase.regionserver.wal.TestLogRolling)  Time elapsed: 713.958 sec  <<< ERROR!
java.io.FileNotFoundException: File does not exist: hdfs://localhost:54304/user/zhihyu/.logs/10.246.204.38,54320,1320336018579/10.246.204.38%3A54320.1320336018858
  at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:466)
  at org.apache.hadoop.fs.FileSystem.getLength(FileSystem.java:676)
  at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1424)
  at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1419)
  at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader$WALReader.<init>(SequenceFileLogReader.java:57)
  at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.init(SequenceFileLogReader.java:158)
  at org.apache.hadoop.hbase.regionserver.wal.HLog.getReader(HLog.java:629)
  at org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnPipelineRestart(TestLogRolling.java:489)
{code}
In the test output, I saw:
{code}
2011-11-03 09:14:06,358 ERROR [Shutdown of DFS[DFSClient[clientName=DFSClient_hb_rs_10.246.204.38,54321,1320336018597_1320336018852, ugi=zhihyu.hfs.1,supergroup]]] hdfs.DFSClient$LeaseChecker(1074): Exception closing file /user/zhihyu/.logs/10.246.204.38,54321,1320336018597/10.246.204.38%3A54321.1320336374373 : java.io.IOException: Error Recovery for block blk_-8007982726961331998_1076 failed  because recovery from primary datanode 127.0.0.1:54952 failed 6 times.  Pipeline was 127.0.0.1:54952. Aborting...
java.io.IOException: Error Recovery for block blk_-8007982726961331998_1076 failed  because recovery from primary datanode 127.0.0.1:54952 failed 6 times.  Pipeline was 127.0.0.1:54952. Aborting...
  at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.processDatanodeError(DFSClient.java:2741)
  at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.access$1500(DFSClient.java:2172)
  at org.apache.hadoop.hdfs.DFSClient$DFSOutputStream$DataStreamer.run(DFSClient.java:2371)
{code}

I ran the test by itself and got same result.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150062#comment-13150062 ] 

Jonathan Hsieh commented on HBASE-4718:
---------------------------------------

Patch *failed* to apply..
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Attachment:     (was: hbase-4552.v4.patch)
    
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Assignee: Jonathan Hsieh
      Status: Patch Available  (was: Open)
    
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch

Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150667#comment-13150667 ] 

Ted Yu commented on HBASE-4718:
-------------------------------

Integrated to 0.90 branch.

Thanks for the patch Jonathan.
                
> Backport HBASE-4552 to 0.90 branch
> ----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.90.5
>
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-4718:
----------------------------------

    Attachment: hbase-4718.v4.patch
    
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch, hbase-4718.v3.includes-hbase-3316.patch, hbase-4718.v4.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4718:
--------------------------

    Attachment: 4718-v2.90

Patch v2 combines HBASE-4552, HBASE-4716 and HBASE-3316
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: 4718-v2.90, hbase-4718.0.90.patch
>
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4718) Backport HBASE-4552 to 0.90 branch.

Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141449#comment-13141449 ] 

Jonathan Hsieh commented on HBASE-4718:
---------------------------------------

An initial backport was done by apurtell.  I've taken it and made it work against 0.90.  It requires a backport of HBASE-3316.  Before I submit, I would like test cross version RPC to verify compatibility or reasonable warning messages.

If it is decided not to integrate, I will post the patch after testing.
                
> Backport HBASE-4552 to 0.90 branch.
> -----------------------------------
>
>                 Key: HBASE-4718
>                 URL: https://issues.apache.org/jira/browse/HBASE-4718
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jonathan Hsieh
>
> In discussion of HBASE-4552 / HBASE-4677 there has been some discussion about whether and how to backport HBASE-4552 to the 0.90 branch.  This is a potentially compatibility breaking so several approaches hav ebeen suggested.
> 1) provide patch but do not integrate
> 2) integrate patch that extends and deprecates old api without removing old api.  It has been argued that  clients are supposed to use LoadIncrementalHFiles api and not at the internal HRegionServer RPC api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira