You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/11 03:36:47 UTC
[GitHub] [dubbo-samples] jianran opened a new pull request, #572: block test case if assert failed in dubbo-samples-async-simple
jianran opened a new pull request, #572:
URL: https://github.com/apache/dubbo-samples/pull/572
# What is the purpose of the change
###### if Assert.assertEquals("hello, completable future", retValue); is fail in helloFuture, the latch.countDown() wouldn't to execute, and the test case will be blocked, if try the assert and put countDown on the finally, the test will quit so quickly and the fail will not to be marked
## Brief changelog
use AtomicReference in the helloFuture to set the retValue and exception, and validate the value after latch count down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #572: block test case if assert failed in dubbo-samples-async-simple
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged PR #572:
URL: https://github.com/apache/dubbo-samples/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org