You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/08/31 10:28:47 UTC

[PR] test(integration): catch on-disk storage format breaks pre-merge [iggy]

hubcio opened a new pull request, #4003:
URL: https://github.com/apache/iggy/pull/4003

   A change to the on-disk format could ship undetected, and every
   way it fails is silent. A partition whose durable state cannot be
   read is tombstoned while boot still exits 0. Topic options
   degrade per key with no log line at all. Segment files carry no
   version stamp, so a layout change is a misread rather than an
   error. The breaking:storage label already promised this check and
   was wired to nothing.
   
   A server built from origin/master seeds a data directory holding
   sealed and active segments, a forced metadata checkpoint,
   consumer and group offsets, a purged topic, users and
   permissions. The binary is then swapped to the build under test
   and restarted against that same directory, and everything must
   read back.
   
   One process and one test rather than a two-phase handoff:
   restart() re-reads executable_path on every call and stop() never
   touches the data directory, so no staging area or cross-process
   manifest is needed. Both binaries are built explicitly, because
   the integration crate has no dependency on the server and nextest
   alone would run whatever stale binary sits in target, comparing
   master against master and reporting green forever.
   
   The assertions check data, never that the server booted. Topic
   options are seeded non-default so a lost key cannot masquerade as
   a re-derived default, and the segment set is compared byte for
   byte to catch a truncating misparse that a readback would miss.
   breaking:storage skips the check, resolved from live labels
   rather than the webhook payload so it still works on a re-run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(integration): catch on-disk storage format breaks pre-merge [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4003:
URL: https://github.com/apache/iggy/pull/4003#issuecomment-5490159797

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4003?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 84.05%. Comparing base ([`bb97397`](https://app.codecov.io/gh/apache/iggy/commit/bb973973d2158930a220dfb813cac613cf7bf599?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ddfb920`](https://app.codecov.io/gh/apache/iggy/commit/ddfb9203e6ecc2401f0d9108821a1453ec5f373a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4003      +/-   ##
   ============================================
   - Coverage     84.97%   84.05%   -0.92%     
     Complexity     1402     1402              
   ============================================
     Files          1225     1223       -2     
     Lines        180182   179932     -250     
     Branches     146486   146442      -44     
   ============================================
   - Hits         153107   151241    -1866     
   - Misses        23043    24692    +1649     
   + Partials       4032     3999      -33     
   ```
   
   | [Components](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.86% <ø> (-0.01%)` | :arrow_down: |
   | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.29% <ø> (ø)` | |
   | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.37% <ø> (ø)` | |
   | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.06% <ø> (ø)` | |
   | [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.65% <ø> (ø)` | |
   | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.90% <ø> (-6.35%)` | :arrow_down: |
   | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4003/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.08% <ø> (-13.24%)` | :arrow_down: |
   [see 94 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4003/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(integration): catch on-disk storage format breaks pre-merge [iggy]

Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #4003:
URL: https://github.com/apache/iggy/pull/4003


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org