You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "kumaab (via GitHub)" <gi...@apache.org> on 2023/05/15 22:51:25 UTC

[GitHub] [ranger] kumaab opened a new pull request, #256: RANGER-4237: Add update_credentials.py to update usernames/passwords

kumaab opened a new pull request, #256:
URL: https://github.com/apache/ranger/pull/256

   ## What changes were proposed in this pull request?
   
   Aims to replace existing scripts with update_credentials.py
   
   Fixes the following:
   * changepasswordutil.py exposes passwords while taking input, use getpass instead.
   * unused imports
   * RMI call to java may hang indefinitely in case the command doesn't complete, add a timeout(60s) instead.
   * Redundant logging constructs
   * Fix while loops for parsing user input
   * Use argparse & getpass to parse input
   * Avoid sys.exit(1) in function calls to be more reusable.
   * migrate to python3
   * Consolidate functionalities to the CredManager class.
   
   
   
   ## How was this patch tested?
   
   Tested username and password updates on ubuntu successfully using docker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ranger] mneethiraj commented on pull request #256: RANGER-4237: Add update_credentials.py to update usernames/passwords

Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on PR #256:
URL: https://github.com/apache/ranger/pull/256#issuecomment-1548749306

   @kumaab - existing utilities changepasswordutil.py and changeusernameutil.py allow parameters to be passed via command-line, which makes it easier to invoke these utilities from scripts. The new script seems to support only interactive input of parameters. I suggest to retain support for command-line parameters.
   
   Also, removal of existing utilities would likely break deployment tools (like Ambari?). Consider updating existing scripts, instead of replacing them with a new one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ranger] kumaab commented on pull request #256: RANGER-4237: Add update_credentials.py to update usernames/passwords

Posted by "kumaab (via GitHub)" <gi...@apache.org>.
kumaab commented on PR #256:
URL: https://github.com/apache/ranger/pull/256#issuecomment-1548765880

   @mneethiraj 
   
   Sure, will update review to support command-line for new usernames and passwords as well.
   
   From @pradeepagrawal8184's comment in https://reviews.apache.org/r/73937/, it looks like ambari scripts are not used anymore/ ambari doesn't support python3. The new script also follows PEP-8 guidelines for naming conventions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org