[GitHub] marcoabreu commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #10297: [MXNET-244] Fixes for cross compilation in ARM
URL: https://github.com/apache/incubator-mxnet/pull/10297#discussion_r193727375
 
 

 ##########
 File path: tests/python/unittest/test_ndarray.py
 ##########
 @@ -711,9 +711,8 @@ def get_values(ensure_unique):
                  k=dat_size*dat_size*dat_size*dat_size, is_ascend=False)
     assert_almost_equal(nd_ret_argsort, gt)
 
-    # test topk with a big shape
-    a = mx.nd.arange(0, 54686454, step=1, repeat=1)
-    assert_almost_equal(a.topk(k=54686454).asnumpy(), a.asnumpy()[::-1])
+    a = mx.nd.arange(0, 1024, step=1, repeat=1)
 
 Review comment:
   As stated before, this test must not be changed as it's there for a reason. Alternatively, provide a C++ test to cover this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services