You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/21 01:02:55 UTC
[GitHub] [geode] jinmeiliao commented on a change in pull request #7207: GEODE-9900: ensure AuthenticationExpiredException handling
jinmeiliao commented on a change in pull request #7207:
URL: https://github.com/apache/geode/pull/7207#discussion_r772759601
##########
File path: geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/command/CloseCQ.java
##########
@@ -111,6 +112,13 @@ public void cmdExecute(final @NotNull Message clientMessage,
sendCqResponse(MessageType.CQ_EXCEPTION_TYPE, "", clientMessage.getTransactionId(), cqe,
serverConnection);
return;
+ } catch (AuthenticationExpiredException e) {
+ if (serverConnection.getTransientFlag(REQUIRES_CHUNKED_RESPONSE)) {
Review comment:
from line 61 of this command, this command does require chunked response, I think you can get rid of the if/else block and just send chunked exception. Same for the other command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org