You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by gi...@apache.org on 2026/08/31 17:32:12 UTC

(seatunnel) 01/01: [Improve][Connector-V2][MongoDB] Migrate fetch size validation to declarative OptionRule (#11886)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/dev/pr-11886-b4158f01ddf9c3a1dda3a48a559d4ae6aec557d2
in repository https://gitbox.apache.org/repos/asf/seatunnel.git

commit f4840f1c7e12c301b8cdb24cb2ae5fcd15ff5ab1
Author: AMAN MISHRA <am...@gmail.com>
AuthorDate: Mon Aug 31 17:31:46 2026 +0000

    [Improve][Connector-V2][MongoDB] Migrate fetch size validation to declarative OptionRule (#11886)
---
 .../mongodb/source/MongodbSourceFactory.java       |  5 +-
 .../mongodb/source/config/MongodbReadOptions.java  |  3 -
 .../seatunnel/mongodb/MongodbFactoryTest.java      | 72 +++++++++++++++++++++-
 3 files changed, 74 insertions(+), 6 deletions(-)

diff --git a/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceFactory.java b/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceFactory.java
index 915ff046fd..f0ecb3b1ff 100644
--- a/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceFactory.java
+++ b/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/MongodbSourceFactory.java
@@ -18,6 +18,7 @@
 package org.apache.seatunnel.connectors.seatunnel.mongodb.source;
 
 import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.configuration.util.Conditions;
 import org.apache.seatunnel.api.configuration.util.OptionRule;
 import org.apache.seatunnel.api.options.ConnectorCommonOptions;
 import org.apache.seatunnel.api.source.SeaTunnelSource;
@@ -56,8 +57,10 @@ public class MongodbSourceFactory implements TableSourceFactory {
                         MongodbSourceOptions.SPLIT_SIZE,
                         MongodbSourceOptions.SPLIT_KEY,
                         MongodbSourceOptions.CURSOR_NO_TIMEOUT,
-                        MongodbSourceOptions.FETCH_SIZE,
                         MongodbSourceOptions.MAX_TIME_MIN)
+                .optional(
+                        MongodbSourceOptions.FETCH_SIZE,
+                        Conditions.greaterThan(MongodbSourceOptions.FETCH_SIZE, 0))
                 .build();
     }
 
diff --git a/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/config/MongodbReadOptions.java b/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/config/MongodbReadOptions.java
index 5644bf129d..3ee0ac732b 100644
--- a/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/config/MongodbReadOptions.java
+++ b/seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/config/MongodbReadOptions.java
@@ -24,8 +24,6 @@ import lombok.Getter;
 
 import java.io.Serializable;
 
-import static org.apache.seatunnel.shade.com.google.common.base.Preconditions.checkArgument;
-
 /** The configuration class for MongoDB source. */
 @EqualsAndHashCode
 @Getter
@@ -61,7 +59,6 @@ public class MongodbReadOptions implements Serializable {
         private MongoReadOptionsBuilder() {}
 
         public MongoReadOptionsBuilder setFetchSize(int fetchSize) {
-            checkArgument(fetchSize > 0, "The fetch size must be larger than 0.");
             this.fetchSize = fetchSize;
             return this;
         }
diff --git a/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb/MongodbFactoryTest.java b/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb/MongodbFactoryTest.java
index 88053f7d1a..3d0004d631 100644
--- a/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb/MongodbFactoryTest.java
+++ b/seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb/MongodbFactoryTest.java
@@ -17,17 +17,85 @@
 
 package org.apache.seatunnel.connectors.seatunnel.mongodb;
 
+import org.apache.seatunnel.api.configuration.ReadonlyConfig;
+import org.apache.seatunnel.api.configuration.util.ConfigValidator;
+import org.apache.seatunnel.api.configuration.util.OptionValidationException;
+import org.apache.seatunnel.api.options.ConnectorCommonOptions;
+import org.apache.seatunnel.connectors.seatunnel.mongodb.config.MongodbSourceOptions;
 import org.apache.seatunnel.connectors.seatunnel.mongodb.sink.MongodbSinkFactory;
 import org.apache.seatunnel.connectors.seatunnel.mongodb.source.MongodbSourceFactory;
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
 class MongodbFactoryTest {
 
+    private final MongodbSourceFactory sourceFactory = new MongodbSourceFactory();
+
     @Test
     void optionRule() {
-        Assertions.assertNotNull((new MongodbSourceFactory()).optionRule());
-        Assertions.assertNotNull((new MongodbSinkFactory()).optionRule());
+        Assertions.assertNotNull(sourceFactory.optionRule());
+        Assertions.assertNotNull(new MongodbSinkFactory().optionRule());
+    }
+
+    @Test
+    void testDefaultFetchSizePassesOptionValidation() {
+        Assertions.assertDoesNotThrow(() -> validateSourceOptionRule(validSourceConfig()));
+    }
+
+    @Test
+    void testPositiveFetchSizePassesOptionValidation() {
+        Map<String, Object> config = validSourceConfig();
+        config.put(MongodbSourceOptions.FETCH_SIZE.key(), 1);
+
+        Assertions.assertDoesNotThrow(() -> validateSourceOptionRule(config));
+
+        config.put(MongodbSourceOptions.FETCH_SIZE.key(), 2048);
+        Assertions.assertDoesNotThrow(() -> validateSourceOptionRule(config));
+    }
+
+    @Test
+    void testZeroFetchSizeFailsOptionValidation() {
+        Map<String, Object> config = validSourceConfig();
+        config.put(MongodbSourceOptions.FETCH_SIZE.key(), 0);
+
+        OptionValidationException exception =
+                Assertions.assertThrows(
+                        OptionValidationException.class, () -> validateSourceOptionRule(config));
+
+        Assertions.assertTrue(
+                exception.getMessage().contains(MongodbSourceOptions.FETCH_SIZE.key()));
+    }
+
+    @Test
+    void testNegativeFetchSizeFailsOptionValidation() {
+        Map<String, Object> config = validSourceConfig();
+        config.put(MongodbSourceOptions.FETCH_SIZE.key(), -1);
+
+        OptionValidationException exception =
+                Assertions.assertThrows(
+                        OptionValidationException.class, () -> validateSourceOptionRule(config));
+
+        Assertions.assertTrue(
+                exception.getMessage().contains(MongodbSourceOptions.FETCH_SIZE.key()));
+    }
+
+    private void validateSourceOptionRule(Map<String, Object> config) {
+        ConfigValidator.of(ReadonlyConfig.fromMap(config)).validate(sourceFactory.optionRule());
+    }
+
+    private Map<String, Object> validSourceConfig() {
+        Map<String, Object> config = new HashMap<>();
+        config.put(MongodbSourceOptions.URI.key(), "mongodb://localhost:27017");
+        config.put(MongodbSourceOptions.DATABASE.key(), "test_database");
+        config.put(MongodbSourceOptions.COLLECTION.key(), "test_collection");
+        config.put(
+                ConnectorCommonOptions.SCHEMA.key(),
+                Collections.singletonMap("fields", Collections.singletonMap("value", "string")));
+        return config;
     }
 }