You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/09/10 07:57:04 UTC

git commit: Improve debug logging for plugin load time messages.

Repository: logging-log4j2
Updated Branches:
  refs/heads/master be6f48a9b -> 0801d8d81


Improve debug logging for plugin load time messages.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/0801d8d8
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/0801d8d8
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/0801d8d8

Branch: refs/heads/master
Commit: 0801d8d813f71aef0d1b9a07c88c72172e6c6eea
Parents: be6f48a
Author: Matt Sicker <ma...@apache.org>
Authored: Wed Sep 10 00:56:44 2014 -0500
Committer: Matt Sicker <ma...@apache.org>
Committed: Wed Sep 10 00:56:59 2014 -0500

----------------------------------------------------------------------
 .../core/config/plugins/util/PluginManager.java | 21 ++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/0801d8d8/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java
index 487f4c7..90dcea0 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginManager.java
@@ -14,6 +14,7 @@
  * See the license for the specific language governing permissions and
  * limitations under the license.
  */
+
 package org.apache.logging.log4j.core.config.plugins.util;
 
 import java.io.BufferedInputStream;
@@ -196,14 +197,18 @@ public class PluginManager {
     }
 
     private void reportPluginLoadDuration(final boolean preLoad, long elapsed) {
-        final StringBuilder sb = new StringBuilder("Generated plugins in ");
-        DecimalFormat numFormat = new DecimalFormat("#0.000000");
+        final DecimalFormat numFormat = new DecimalFormat("#0.000000");
         final double seconds = elapsed / (1000.0 * 1000.0 * 1000.0);
-        sb.append(numFormat.format(seconds)).append(" seconds, packages: ");
-        sb.append(PACKAGES);
-        sb.append(", preload: ");
-        sb.append(preLoad);
-        sb.append(".");
+        final StringBuilder sb = new StringBuilder()
+            .append("Plugin category ")
+            .append(category)
+            .append(" loaded in ")
+            .append(numFormat.format(seconds))
+            .append(" seconds, packages: ")
+            .append(PACKAGES)
+            .append(", preload: ")
+            .append(preLoad)
+            .append(".");
         LOGGER.debug(sb.toString());
     }
 
@@ -304,7 +309,7 @@ public class PluginManager {
         public String toString() {
             final StringBuilder msg = new StringBuilder("annotated with @" + Plugin.class.getSimpleName());
             if (isA != null) {
-                msg.append(" is assignable to " + isA.getSimpleName());
+                msg.append(" is assignable to ").append(isA.getSimpleName());
             }
             return msg.toString();
         }