You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/07 07:39:41 UTC
[GitHub] [spark] MaxGekk opened a new pull request #35416: [WIP][SPARK-38126][SQL] Check the whole message of error classes
MaxGekk opened a new pull request #35416:
URL: https://github.com/apache/spark/pull/35416
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
By running the modified test suites:
```
$ build/sbt "test:testOnly *QueryParsingErrorsSuite"
$ build/sbt "test:testOnly *QueryCompilationErrorsSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35416: [SPARK-38126][SQL][TESTS] Check the whole message of error classes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35416:
URL: https://github.com/apache/spark/pull/35416#discussion_r800726038
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala
##########
@@ -72,9 +72,8 @@ class QueryCompilationErrorsSuite extends QueryTest with SharedSparkSession {
Dataset.ofRows(spark, plan)
}.message
- assert(msg.contains("The feature is not supported: " +
+ assert(msg.matches("The feature is not supported: " +
Review comment:
is this a user-facing error? The test constructs logical plan directly which is not user-facing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35416: [SPARK-38126][SQL][TESTS] Check the whole message of error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35416:
URL: https://github.com/apache/spark/pull/35416#discussion_r800847030
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala
##########
@@ -72,9 +72,8 @@ class QueryCompilationErrorsSuite extends QueryTest with SharedSparkSession {
Dataset.ofRows(spark, plan)
}.message
- assert(msg.contains("The feature is not supported: " +
+ assert(msg.matches("The feature is not supported: " +
Review comment:
The exception was introduced by https://github.com/apache/spark/pull/28572. @Ngone51 Can it be triggered by user code?
Probably, it would be nice to revise all existing error classes/exceptions, and check their visibility to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35416: [SPARK-38126][SQL] Check the whole message of error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35416:
URL: https://github.com/apache/spark/pull/35416#issuecomment-1031264436
@cloud-fan @imback82 @ivoson @SaurabhChawla100 @yutoacts @leesf Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #35416: [SPARK-38126][SQL][TESTS] Check the whole message of error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35416:
URL: https://github.com/apache/spark/pull/35416#issuecomment-1031694863
Merging to master. Thank you, @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35416: [SPARK-38126][SQL][TESTS] Check the whole message of error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35416:
URL: https://github.com/apache/spark/pull/35416#discussion_r800862051
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala
##########
@@ -72,9 +72,8 @@ class QueryCompilationErrorsSuite extends QueryTest with SharedSparkSession {
Dataset.ofRows(spark, plan)
}.message
- assert(msg.contains("The feature is not supported: " +
+ assert(msg.matches("The feature is not supported: " +
Review comment:
Opened SPARK-38131 for the task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #35416: [SPARK-38126][SQL][TESTS] Check the whole message of error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35416:
URL: https://github.com/apache/spark/pull/35416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #35416: [SPARK-38126][SQL][TESTS] Check the whole message of error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #35416:
URL: https://github.com/apache/spark/pull/35416#discussion_r800847030
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala
##########
@@ -72,9 +72,8 @@ class QueryCompilationErrorsSuite extends QueryTest with SharedSparkSession {
Dataset.ofRows(spark, plan)
}.message
- assert(msg.contains("The feature is not supported: " +
+ assert(msg.matches("The feature is not supported: " +
Review comment:
The exception was introduced by https://github.com/apache/spark/pull/28572. @Ngone51 Can it be triggered by user code?
Probably, it would be nice to revise all existing error classes/exception, and check their visibility to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org