You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/17 09:16:32 UTC
[GitHub] [superset] geido opened a new pull request, #20093: chore: Add the tnum font property to Table components
geido opened a new pull request, #20093:
URL: https://github.com/apache/superset/pull/20093
### SUMMARY
Added the `tnum` property to the TableCollection component which is used in most lists and Time-series Table chart
### BEFORE
<img width="1677" alt="lists_before" src="https://user-images.githubusercontent.com/60598000/168775345-6b06aa3b-f516-4860-b881-abb06c206e5f.png">
### AFTER
<img width="1677" alt="lists_after" src="https://user-images.githubusercontent.com/60598000/168775395-7c0d36bb-2d17-4733-8e1e-7dc3dfd44f63.png">
Added the `tnum` property to the Pivot Table v2 component
### BEFORE
<img width="1374" alt="pivot_table_v2_before" src="https://user-images.githubusercontent.com/60598000/168775531-4c642a30-3b16-4de7-8289-6490bb4bb6b3.png">
### AFTER
<img width="1380" alt="pivot_table_v2_after" src="https://user-images.githubusercontent.com/60598000/168775579-950e9591-480b-44c7-ba1a-26eee6201737.png">
Added the tnum` `property to the Pivot Table v1 component
### BEFORE
<img width="1382" alt="pivot_table_before" src="https://user-images.githubusercontent.com/60598000/168775636-cd5c90b3-b1de-4a28-9cba-84f765353dc4.png">
### AFTER
<img width="1381" alt="pivot_table_after" src="https://user-images.githubusercontent.com/60598000/168775690-d75fc243-205b-4d97-80e7-b0f6c43e45c1.png">
Added the `tnum` property to the Paired t-test table component
### BEFORE
<img width="1381" alt="paired_t_test_before" src="https://user-images.githubusercontent.com/60598000/168775733-eb1165a6-cf0d-47b9-bc33-a6a7c6573404.png">
### AFTER
<img width="1383" alt="paired_t_test_after" src="https://user-images.githubusercontent.com/60598000/168775764-0a3dddb2-226a-4586-aa0e-ed7f43734fd4.png">
CollectionTable used in the Datasource modal already has the `tnum` property. No additional changes are required. The same applies to all tables using Antdesign
FilterableTable used in the result set of SqlLab already has the `tnum` property. No additional changes are required. The same applies to all tables using react-virtualized
The viz type Table has the `tnum` property. No additional changes are required
### TESTING INSTRUCTIONS
1. Open all Tables as presented above
2. Make sure the numbers in the cells are using the [tnum](https://developer.mozilla.org/en-US/docs/Web/CSS/font-feature-settings) font property
3. Make sure all tables are still appearing as intended
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #20093: chore: Add the tnum font property to Table components
Posted by GitBox <gi...@apache.org>.
geido merged PR #20093:
URL: https://github.com/apache/superset/pull/20093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20093: chore: Add the tnum font property to Table components
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20093:
URL: https://github.com/apache/superset/pull/20093#issuecomment-1128664055
# [Codecov](https://codecov.io/gh/apache/superset/pull/20093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20093](https://codecov.io/gh/apache/superset/pull/20093?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6f184f) into [master](https://codecov.io/gh/apache/superset/commit/9854d2d0e8f849366b264353819c6fdf4b0d804d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9854d2d) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #20093 +/- ##
==========================================
- Coverage 66.37% 66.36% -0.02%
==========================================
Files 1715 1716 +1
Lines 64179 64280 +101
Branches 6753 6796 +43
==========================================
+ Hits 42602 42662 +60
- Misses 19859 19888 +29
- Partials 1718 1730 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.36% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20093?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhaXJlZC10LXRlc3Qvc3JjL1BhaXJlZFRUZXN0LmpzeA==) | `0.00% <ø> (ø)` | |
| [...n-chart-pivot-table/src/react-pivottable/Styles.js](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvU3R5bGVzLmpz) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/Chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvQ2hhcnQuanN4) | `52.54% <ø> (ø)` | |
| [...-frontend/src/components/TableCollection/index.tsx](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVDb2xsZWN0aW9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...charts/src/Timeseries/Regular/Bar/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9jb250cm9sUGFuZWwudHN4) | `34.48% <0.00%> (-5.52%)` | :arrow_down: |
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `65.20% <0.00%> (-4.17%)` | :arrow_down: |
| [...plugins/plugin-chart-echarts/src/utils/forecast.ts](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvZm9yZWNhc3QudHM=) | `93.22% <0.00%> (-1.61%)` | :arrow_down: |
| [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | `50.40% <0.00%> (-1.24%)` | :arrow_down: |
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `56.86% <0.00%> (-1.04%)` | :arrow_down: |
| [...d/plugins/plugin-chart-echarts/src/utils/series.ts](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvc2VyaWVzLnRz) | `92.00% <0.00%> (-0.96%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/20093/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20093?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20093?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9854d2d...b6f184f](https://codecov.io/gh/apache/superset/pull/20093?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org