[jira] [Commented] (MESOS-5384) Improve error message for missing resources file

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566604#comment-15566604 ] 

Benjamin Mahler commented on MESOS-5384:
----------------------------------------

[~Kris Paprocki] looking at the code between fetch.hpp and parse.hpp in stout/flags, it appears that {{file://}} prefixes are required for loading flags from a file. However, the code in parse.hpp (as the comment indicates) remains in place from when we allowed users to specify json objects and arrays via {{/path/without/the/file/scheme/prefix}}.

It looks like you're proposing to remove the backwards compatibility logic to allow json objects and arrays to be parsed by non-{{file://}} paths. However, this may break some existing users, we would have to warn them that this change is happening so that they can change their flag values before they upgrade. Feel free to file a separate ticket for removing this, we can tag it as a backwards incompatible change we need to make.

Does this solve the problem though? It looks like we may just need to update the documentation here and figure out if we can provide a helpful error message.

> Improve error message for missing resources file
> ------------------------------------------------
>
>                 Key: MESOS-5384
>                 URL: https://issues.apache.org/jira/browse/MESOS-5384
>             Project: Mesos
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 0.28.1
>         Environment: Centos 7
>            Reporter: John Yost
>            Assignee: Kris Paprocki
>            Priority: Minor
>              Labels: easyfix, newbie
>
> Attempting to specify resources file via --resources=/etc/mesos-slave/small-slave-config.json threw the following error:
> Failed to determine slave resources: Bad value for resources, missing or extra ':' in /etc/mesos-slave/small-slave-config.json
> I confirmed I had valid JSON: 
> [
>   {
>     "name": "cpus",
>     "type": "SCALAR",
>     "scalar": {
>       "value": 0.5
>     }
>   },
>   {
>     "name": "mem",
>     "type": "SCALAR",
>     "scalar": {
>       "value": 512
>     }
>   }
> ]
> In actuality, I misread to docs with my file pattern. Once I changed to resources=file:///etc/mesos-slave/small-slave-config.json the mesos slave started up fine. Just need a missing file check and corresponding error message to fix this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)