[GitHub] [solr] noblepaul commented on a change in pull request #403: SOLR-15694 Concept of node roles and non-data nodes

[GitBox <gi...@apache.org>]

noblepaul commented on a change in pull request #403:
URL: https://github.com/apache/solr/pull/403#discussion_r773652976



##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -944,6 +946,14 @@ public void load() {
       });
 
       clusterSingletons.setReady();
+      if (NodeRoles.PREFERRED.equals(nodeRoles.getRoleMode(NodeRoles.Role.OVERSEER))) {
+        try {
+          log.info("This node is started as a preferred overseer");

Review comment:
       @janhoy 
   
   I agree with @murblanc . It's hard to have a generic interface to perform the logic of a role. The place in which this code is executed is very important. it may also alter the behavior of existing classes. However, it may be possible to have a generic interface for roles for certain roles that will come up in the future. The current design doesn't stop us from doing so




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org