You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/02/26 21:11:08 UTC
[kudu-CR] test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12598
Change subject: test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
......................................................................
test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
We should wait for the replica to become leader so it's usable for
writes. Without this fix, the test failed 81/1000 times in release mode,
and passed 1000/1000 with it.
Change-Id: Ie6016f717183ca7bcf98c0874a24f1463e113cef
---
M src/kudu/tablet/tablet_replica-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/12598/1
--
To view, visit http://gerrit.cloudera.org:8080/12598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6016f717183ca7bcf98c0874a24f1463e113cef
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12598 )
Change subject: test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
......................................................................
test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
We should wait for the replica to become leader so it's usable for
writes. Without this fix, the test failed 81/1000 times in release mode,
and passed 1000/1000 with it.
Change-Id: Ie6016f717183ca7bcf98c0874a24f1463e113cef
Reviewed-on: http://gerrit.cloudera.org:8080/12598
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tablet/tablet_replica-test.cc
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6016f717183ca7bcf98c0874a24f1463e113cef
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12598 )
Change subject: test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12598/1/src/kudu/tablet/tablet_replica-test.cc
File src/kudu/tablet/tablet_replica-test.cc:
http://gerrit.cloudera.org:8080/#/c/12598/1/src/kudu/tablet/tablet_replica-test.cc@237
PS1, Line 237: const MonoDelta kTimeout = MonoDelta::FromSeconds(10);
Could even make this longer (i.e. 30s). No real reason for it to be short, right?
--
To view, visit http://gerrit.cloudera.org:8080/12598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6016f717183ca7bcf98c0874a24f1463e113cef
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Feb 2019 22:07:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12598 )
Change subject: test: deflake TabletReplicaTest.TestRollLogSegmentSchemaOnAlter
......................................................................
Patch Set 2: Code-Review+2
Carrying forward the +2.
--
To view, visit http://gerrit.cloudera.org:8080/12598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6016f717183ca7bcf98c0874a24f1463e113cef
Gerrit-Change-Number: 12598
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Feb 2019 23:47:27 +0000
Gerrit-HasComments: No