You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/06 01:32:38 UTC
Re: Review Request 18551: Added ABORT_MSG usage in mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/
-----------------------------------------------------------
(Updated March 5, 2014, 4:32 p.m.)
Review request for mesos and Benjamin Hindman.
Summary (updated)
-----------------
Added ABORT_MSG usage in mesos
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/exec/exec.cpp 0ab5cc20b3f86ce7f6723ef29e7a3a69d056b4ca
src/java/jni/org_apache_mesos_state_AbstractState.cpp 0c7aebf118f7c892c61ab0c9ce92187293047f82
src/log/leveldb.cpp f8c0f6559e86cadaaefcadc956b947c89a857a64
src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
src/log/network.hpp 9c76bf8b2e04485da665963f104477e1324378a7
src/log/recover.cpp 3403b47e0bfb76c8a29fa21fb416ec6449ded9ed
src/slave/containerizer/cgroups_launcher.cpp a9b0108d75d0780d8c6abc82bec859ae4844c0e1
src/slave/containerizer/launcher.cpp 2361a20f361dc6b360770945329067de95cfd3fc
src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
Diff: https://reviews.apache.org/r/18551/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18551: Added ABORT_MSG usage in mesos
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/#review36309
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 6, 2014, 12:32 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18551/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 12:32 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1041
> https://issues.apache.org/jira/browse/MESOS-1041
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 0ab5cc20b3f86ce7f6723ef29e7a3a69d056b4ca
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 0c7aebf118f7c892c61ab0c9ce92187293047f82
> src/log/leveldb.cpp f8c0f6559e86cadaaefcadc956b947c89a857a64
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/log/network.hpp 9c76bf8b2e04485da665963f104477e1324378a7
> src/log/recover.cpp 3403b47e0bfb76c8a29fa21fb416ec6449ded9ed
> src/slave/containerizer/cgroups_launcher.cpp a9b0108d75d0780d8c6abc82bec859ae4844c0e1
> src/slave/containerizer/launcher.cpp 2361a20f361dc6b360770945329067de95cfd3fc
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
>
> Diff: https://reviews.apache.org/r/18551/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18551: Added ABORT_MSG usage in mesos
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/
-----------------------------------------------------------
(Updated March 6, 2014, 10:52 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/exec/exec.cpp 0ab5cc20b3f86ce7f6723ef29e7a3a69d056b4ca
src/java/jni/org_apache_mesos_state_AbstractState.cpp 0c7aebf118f7c892c61ab0c9ce92187293047f82
src/log/leveldb.cpp f8c0f6559e86cadaaefcadc956b947c89a857a64
src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
src/log/network.hpp 9c76bf8b2e04485da665963f104477e1324378a7
src/log/recover.cpp 3403b47e0bfb76c8a29fa21fb416ec6449ded9ed
src/slave/containerizer/cgroups_launcher.cpp a9b0108d75d0780d8c6abc82bec859ae4844c0e1
src/slave/containerizer/launcher.cpp 2361a20f361dc6b360770945329067de95cfd3fc
src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
Diff: https://reviews.apache.org/r/18551/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18551: Added ABORT_MSG usage in mesos
Posted by Dominic Hamon <dh...@twopensource.com>.
> On March 5, 2014, 5:06 p.m., Benjamin Hindman wrote:
> > src/exec/exec.cpp, line 686
> > <https://reviews.apache.org/r/18551/diff/4/?file=511674#file511674line686>
> >
> > Any reason not to do CHECK_SOME here?
_recoveryTimeout is a Try, not an Option.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/#review36313
-----------------------------------------------------------
On March 5, 2014, 5:02 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18551/
> -----------------------------------------------------------
>
> (Updated March 5, 2014, 5:02 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1041
> https://issues.apache.org/jira/browse/MESOS-1041
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 0ab5cc20b3f86ce7f6723ef29e7a3a69d056b4ca
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 0c7aebf118f7c892c61ab0c9ce92187293047f82
> src/log/leveldb.cpp f8c0f6559e86cadaaefcadc956b947c89a857a64
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/log/network.hpp 9c76bf8b2e04485da665963f104477e1324378a7
> src/log/recover.cpp 3403b47e0bfb76c8a29fa21fb416ec6449ded9ed
> src/slave/containerizer/cgroups_launcher.cpp a9b0108d75d0780d8c6abc82bec859ae4844c0e1
> src/slave/containerizer/launcher.cpp 2361a20f361dc6b360770945329067de95cfd3fc
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
>
> Diff: https://reviews.apache.org/r/18551/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18551: Added ABORT_MSG usage in mesos
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 6, 2014, 1:06 a.m., Benjamin Hindman wrote:
> > src/exec/exec.cpp, line 686
> > <https://reviews.apache.org/r/18551/diff/4/?file=511674#file511674line686>
> >
> > Any reason not to do CHECK_SOME here?
>
> Dominic Hamon wrote:
> _recoveryTimeout is a Try, not an Option.
Yup, and CHECK_SOME can take an Option, a Try, or a Result.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/#review36313
-----------------------------------------------------------
On March 6, 2014, 1:02 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18551/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 1:02 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1041
> https://issues.apache.org/jira/browse/MESOS-1041
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 0ab5cc20b3f86ce7f6723ef29e7a3a69d056b4ca
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 0c7aebf118f7c892c61ab0c9ce92187293047f82
> src/log/leveldb.cpp f8c0f6559e86cadaaefcadc956b947c89a857a64
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/log/network.hpp 9c76bf8b2e04485da665963f104477e1324378a7
> src/log/recover.cpp 3403b47e0bfb76c8a29fa21fb416ec6449ded9ed
> src/slave/containerizer/cgroups_launcher.cpp a9b0108d75d0780d8c6abc82bec859ae4844c0e1
> src/slave/containerizer/launcher.cpp 2361a20f361dc6b360770945329067de95cfd3fc
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
>
> Diff: https://reviews.apache.org/r/18551/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18551: Added ABORT_MSG usage in mesos
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/#review36313
-----------------------------------------------------------
src/exec/exec.cpp
<https://reviews.apache.org/r/18551/#comment67274>
Any reason not to do CHECK_SOME here?
- Benjamin Hindman
On March 6, 2014, 1:02 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18551/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 1:02 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1041
> https://issues.apache.org/jira/browse/MESOS-1041
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 0ab5cc20b3f86ce7f6723ef29e7a3a69d056b4ca
> src/java/jni/org_apache_mesos_state_AbstractState.cpp 0c7aebf118f7c892c61ab0c9ce92187293047f82
> src/log/leveldb.cpp f8c0f6559e86cadaaefcadc956b947c89a857a64
> src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
> src/log/network.hpp 9c76bf8b2e04485da665963f104477e1324378a7
> src/log/recover.cpp 3403b47e0bfb76c8a29fa21fb416ec6449ded9ed
> src/slave/containerizer/cgroups_launcher.cpp a9b0108d75d0780d8c6abc82bec859ae4844c0e1
> src/slave/containerizer/launcher.cpp 2361a20f361dc6b360770945329067de95cfd3fc
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
> src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
>
> Diff: https://reviews.apache.org/r/18551/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18551: Added ABORT_MSG usage in mesos
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18551/
-----------------------------------------------------------
(Updated March 5, 2014, 5:02 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/exec/exec.cpp 0ab5cc20b3f86ce7f6723ef29e7a3a69d056b4ca
src/java/jni/org_apache_mesos_state_AbstractState.cpp 0c7aebf118f7c892c61ab0c9ce92187293047f82
src/log/leveldb.cpp f8c0f6559e86cadaaefcadc956b947c89a857a64
src/log/log.cpp 7f855f25d97e0caeafa7708951c4ec51ddbc3de4
src/log/network.hpp 9c76bf8b2e04485da665963f104477e1324378a7
src/log/recover.cpp 3403b47e0bfb76c8a29fa21fb416ec6449ded9ed
src/slave/containerizer/cgroups_launcher.cpp a9b0108d75d0780d8c6abc82bec859ae4844c0e1
src/slave/containerizer/launcher.cpp 2361a20f361dc6b360770945329067de95cfd3fc
src/slave/containerizer/mesos_containerizer.cpp 6d990cb1045bb4e68668ad0710eeb2ab5c9bbdb5
src/slave/slave.cpp b350df45c631a8976011eb88435728b6d7623848
Diff: https://reviews.apache.org/r/18551/diff/
Testing
-------
make check
Thanks,
Dominic Hamon