You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by scwf <gi...@git.apache.org> on 2014/04/26 21:05:00 UTC
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/567
spark.storage.memoryFraction indicates the max fraction of memory for spark memory cache
Now the description of spark.storage.memoryFraction may misunderstanding that the fraction of memory only used for spark memory cache. Actually it is only the max value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scwf/spark docfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/567.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #567
----
commit 1d716397c31fa09c44f9abcdf1e46488d47ebf9b
Author: scwf <wa...@huawei.com>
Date: 2014-04-26T18:41:03Z
to indicate the fraction memory is max memory for spark cache
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
Posted by techaddict <gi...@git.apache.org>.
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/567#issuecomment-41485102
@scwf don't worry about this test, its the hive test it takes 50+mins every time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/567#issuecomment-41477729
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/567#issuecomment-41479164
build error: "test run exceeded 50.0 minutes" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
Posted by scwf <gi...@git.apache.org>.
Github user scwf closed the pull request at:
https://github.com/apache/spark/pull/567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/567#issuecomment-41486082
Could you explain what you thought this parameter did? I'm not sure I understand what you are trying to make more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/567#issuecomment-41487284
if java heap = 10g and spark.storage.memoryFraction has default value 0.6, actually it means spark memory cache can use memory up to 0.6*10g and if there is no rdd cache or this fraction of memory has not been used completely, spark task computation can also make use of it.
but now the description may misunderstanding that jvm allocate 0.6*10g only for rdd cache and spark task computation can not make use of this fraction memory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: spark.storage.memoryFraction indicates the max...
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/567#issuecomment-41484924
The test may has some problems. I don't modify any code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---