[jira] [Commented] (SOLR-4914) Refactor core persistence to reflect deprecating the tags in solr.xml

["Alan Woodward (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683363#comment-13683363 ] 

Alan Woodward commented on SOLR-4914:
-------------------------------------

Thanks for opening this, Erick.

I think it makes sense to combine persistence and discovery, as they're basically two sides of the same coin.  So pre Solr 4.3, we loaded cores from solr.xml and persisted them back there.  Now we allow Solr to crawl the filesystem looking for core definition files and we persist these.

I'm thinking the combined interface should look something like this:

{code:java}
public interface CoreDiscoverer {

    public List<CoreDescriptor> discover();

    public void persist(CoreDescriptor cd);
    public void delete(CoreDescriptor cd);

}
{code}

This also allows us to make discovery and persistence completely pluggable.  If I want to store my core definitions in an external DB, or a plain text file, or whatever, I implement a PlainTextCoreDiscoverer and drop it onto the classpath, and refer to it from solr.xml.
                
> Refactor core persistence to reflect deprecating the <core> tags in solr.xml
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-4914
>                 URL: https://issues.apache.org/jira/browse/SOLR-4914
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0
>            Reporter: Erick Erickson
>         Attachments: SOLR-4914.patch
>
>
> Alan Woodward has done some work to refactor how core persistence works that we should work on going forward that I want to separate from a shorter-term tactical problem (See SOLR-4910).
> I'm attaching Alan's patch to this JIRA and we'll carry it forward separately from 4910.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org