You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/29 17:59:27 UTC

[GitHub] [cloudstack] RodrigoDLopez opened a new pull request, #6783: fixes script that perform change password on hosts

RodrigoDLopez opened a new pull request, #6783:
URL: https://github.com/apache/cloudstack/pull/6783

   ### Description
   When adding a KVM host via ACS UI, it is necessary to provide a username and password for ACS to connect via SSH to the host. When using the `updateHostPassword` API, ACS updates the password in the metadata. When the update_passwd_on_host parameter is specified as true, ACS sends a command to the host that causes it to run a script to change the user's password on the host.
   
   During some internal tests, it was observed that the script was not changing the password and returned an error. Adjustments were made to this script to make it work again.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### How Has This Been Tested?
   After executing the `updateHostPassword` API, an attempt was made to access the host via ssh using the user and the new password as a parameter. The expected result is that the password for that user has been updated, and this was the result observed during the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1346292934

   good point @weizhouapache 
   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290239425

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1334896638

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1341293988

   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289201502

   > I run this script on a ubuntu 22.04 host, the password has been changed successfully, but the exit code is 1
   > 
   > ```
   > # /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
   > New password: Retype new password: passwd: password updated successfully
   > # echo $?
   > 1
   > ```
   > 
   > still needs some changes @RodrigoDLopez
   
   I ran the same test with Ubuntu versions 20.04 and 22.04. However, the result in my environment was different from what was reported. 
   
   On ubuntu 20.04:
   ```
   :~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
   New password: Retype new password: passwd: password updated successfully
   :~# 
   ```
   
   On ubuntu 22.04:
   ```
   :~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password123
   New password: Retype new password: passwd: password updated successfully
   :~# 
   ```
   
   can you recheck?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289228158

   > > I run this script on a ubuntu 22.04 host, the password has been changed successfully, but the exit code is 1
   > > ```
   > > # /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
   > > New password: Retype new password: passwd: password updated successfully
   > > # echo $?
   > > 1
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > still needs some changes @RodrigoDLopez
   > 
   > I ran the same test with Ubuntu versions 20.04 and 22.04. However, the result in my environment was different from what was reported.
   > 
   > On ubuntu 20.04:
   > 
   > ```
   > :~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
   > New password: Retype new password: passwd: password updated successfully
   > :~# 
   > ```
   > 
   > On ubuntu 22.04:
   > 
   > ```
   > :~# /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password123
   > New password: Retype new password: passwd: password updated successfully
   > :~# 
   > ```
   > 
   > can you recheck?
   
   @RodrigoDLopez 
   have you checked the exit code of the script ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1338966272

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1277344496

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1274549399

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1280451754

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1339589296

   <b>Trillian Build Failed (tid-5406)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1272269862

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290649595

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6783 (SL-JID-2565)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290639793

   > > @weizhouapache I misunderstood your message, sorry about that. The script has been fixed to return the output code correctly.
   > 
   > @RodrigoDLopez no problem. thanks for your update. actually it was a small issue , because the output (not the exit code) is checked in codebase.
   > 
   > Have you tested any failures, for example, the host has a password policy but the new password is too weak ? What's the output and exit code ?
   
   Yes I tested with password policies. But the password is always changed as the script runs with privileges. I think it would be good for someone else to test this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1335454421

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4751


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1347454635

   <b>Trillian test result (tid-5472)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40496 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5472-kvm-centos7.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #6783: fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1262680348

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6783?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6783](https://codecov.io/gh/apache/cloudstack/pull/6783?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01e82bb) into [main](https://codecov.io/gh/apache/cloudstack/commit/67024b036a0640ee1ee9aa79d0496ce6606aa58c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67024b0) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #6783   +/-   ##
   =========================================
     Coverage     10.52%   10.53%           
   - Complexity     6784     6785    +1     
   =========================================
     Files          2464     2464           
     Lines        243988   243988           
     Branches      38185    38185           
   =========================================
   + Hits          25690    25692    +2     
   + Misses       215065   215063    -2     
     Partials       3233     3233           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6783/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: |
   | [...apache/cloudstack/alert/snmp/SnmpTrapAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6783/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zbm1wLWFsZXJ0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9hbGVydC9zbm1wL1NubXBUcmFwQXBwZW5kZXIuamF2YQ==) | `61.05% <0.00%> (+2.10%)` | :arrow_up: |
   | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6783/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1338966510

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1335563998

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#discussion_r1004585202


##########
scripts/vm/hypervisor/update_host_passwd.sh:
##########
@@ -15,13 +15,16 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
 username=$1
 new_passwd=$2
 expected="successfully."

Review Comment:
   also, `expected is no longer used!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1347474926

   <b>Trillian test result (tid-5471)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41805 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5471-xenserver-71.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1346294439

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290240680

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289337739

   @weizhouapache 
   I misunderstood your message, sorry about that. The script has been fixed to return the output code correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289344882

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6783 (SL-JID-2558)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1272242141

   @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1279408071

   <b>Trillian test result (tid-5124)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40954 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5124-vmware-65u2.zip
   Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1279560791

   <b>Trillian test result (tid-5123)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 51288 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5123-kvm-centos7.zip
   Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3625.43 | test_kubernetes_clusters.py
   test_04_autoscale_kubernetes_cluster | `Failure` | 325.91 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 609.77 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 3604.99 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 3661.26 | test_kubernetes_clusters.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.86 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1338971910

   <b>Trillian Build Failed (tid-5397)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1355138313

   ok, the failures have nothing to do with this code. I also had not understood the functionality completely. redoing some tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1355166136

   tested good on xen and kvm, not supported on vmware: merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#discussion_r1004583908


##########
scripts/vm/hypervisor/update_host_passwd.sh:
##########
@@ -17,13 +17,14 @@
 # under the License.
 username=$1
 new_passwd=$2
+expected="successfully."
 
 passwd ${username} << EOD
 ${new_passwd}
 ${new_passwd}
 EOD
 
-if [[ $(echo $?) ]]; then
+if [[ $(echo $?) -eq 0 ]]; then

Review Comment:
   wouldn´t just letting the script exit already do this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290318044

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4542


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1338963811

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1280453017

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#discussion_r1037888028


##########
scripts/vm/hypervisor/update_host_passwd.sh:
##########
@@ -15,14 +15,16 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
 username=$1
 new_passwd=$2
-expected="successfully."
-result=`echo -e "$new_passwd\n$new_passwd" | passwd --stdin $username | grep successfully | awk '{ print $6 }'`
 
-if [ $result = $expected ]; then
+passwd ${username} << EOD
+${new_passwd}
+${new_passwd}
+EOD
+
+if [[ $(echo $?) -eq 0 ]]; then
    exit 0
 else
    exit 1
-fi
\ No newline at end of file
+fi

Review Comment:
   I don´t mind this part, but just letting the script exit will have all but the same effect; $? will be the exit code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1274601693

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1277193786

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4445


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1277480642

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4455


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1281404475

   I run this script on a ubuntu 22.04 host, the password has been changed successfully, but the exit code is 1
   
   ```
   # /usr/share/cloudstack-common/scripts/vm/hypervisor/update_host_passwd.sh root password
   New password: Retype new password: passwd: password updated successfully
   # echo $?
   1
   ```
   
   still needs some changes
   @RodrigoDLopez 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1279350409

   <b>Trillian test result (tid-5122)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36605 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5122-xenserver-71.zip
   Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289396779

   > @weizhouapache I misunderstood your message, sorry about that. The script has been fixed to return the output code correctly.
   
   @RodrigoDLopez 
   no problem. thanks for your update.
   actually it was a small issue , because the output (not the exit code) is checked in codebase.
   
   Have you tested any failures, for example, the host has a password policy but the new password is too weak ?
   What's the output and exit code ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1272241997

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1348120229

   doing some extra manual tests on assorted environments, @RodrigoDLopez . otherwise ready to merge
   - [ ] rocky8 / kvm
   - [ ] ubuntu22 / kvm
   - [ ] alma9 / vmware
   - [ ] ubuntu20 / xcpng82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1341293340

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1334971271

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1334895792

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1278657224

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1276665973

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289338932

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289409502

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6783)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6783&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6783&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6783&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6783&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6783&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] acs-robot commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290637538

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290733109

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6783)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6783&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6783&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6783&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6783&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6783&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6783&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1347579201

   <b>Trillian test result (tid-5473)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46895 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5473-vmware-65u2.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 676.30 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1340875468

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4796


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1335567464

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4755


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1342112422

   <b>Trillian test result (tid-5419)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45401 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5419-kvm-centos7.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 570.05 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1354364695

   > doing some extra manual tests on assorted environments, @RodrigoDLopez . otherwise ready to merge
   > 
   >     * [x]  rocky8 / kvm
   > 
   >     * [x]  ubuntu22 / kvm
   > 
   >     * [ ]  alma9 / vmware
   > 
   >     * [x]  ubuntu20 / xcpng82
   
   @weizhouapache @RodrigoDLopez , only the vmware version failed. I am now trying a centos7 with vmware to eliminate the alma8 factor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1274548923

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1278658585

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1281376961

   <b>Trillian test result (tid-5144)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39971 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6783-t5144-kvm-centos7.zip
   Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 599.87 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1290638546

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] acs-robot commented on pull request #6783: Fixes script that perform change password on hosts

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6783:
URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1289337901

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org