You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2009/02/14 02:04:39 UTC
Re: thoughts?
[cc'ing list; dev: just a short email to hyrum, but wanted to expand
audience now]
It "shouldn't" ... cachable_props is only ever set to
SVN_WC__CACHABLE_PROPS, and nobody ever attempts to change it.
Further, in props.c::build_present_props(), it doesn't even *look* at
cachable_props, but uses the constant instead. If somebody *did*
happen to change the value, then it wouldn't matter in the least.
But let's say I introduced a bug... how the heck would I test the
propcaching performance?
On Fri, Feb 13, 2009 at 18:16, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> Looks okay. How does it affect propcaching performance?
>
> On Feb 13, 2009, at 2:11 AM, Greg Stein wrote:
>
>> http://paste.lisp.org/display/75405
>
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1154635
Re: thoughts?
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Feb 13, 2009, at 8:04 PM, Greg Stein wrote:
> [cc'ing list; dev: just a short email to hyrum, but wanted to expand
> audience now]
>
> It "shouldn't" ... cachable_props is only ever set to
> SVN_WC__CACHABLE_PROPS, and nobody ever attempts to change it.
> Further, in props.c::build_present_props(), it doesn't even *look* at
> cachable_props, but uses the constant instead. If somebody *did*
> happen to change the value, then it wouldn't matter in the least.
In that case, it looks like removing it is better than pretending to
honor any changes a consumer may make to the value. (And I notice
you've done so in r35868.)
> But let's say I introduced a bug... how the heck would I test the
> propcaching performance?
I have no idea.
> On Fri, Feb 13, 2009 at 18:16, Hyrum K. Wright
> <hy...@mail.utexas.edu> wrote:
>> Looks okay. How does it affect propcaching performance?
>>
>> On Feb 13, 2009, at 2:11 AM, Greg Stein wrote:
>>
>>> http://paste.lisp.org/display/75405
>>
>>
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1154635
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1154975