[jira] [Comment Edited] (SENTRY-1794) HMSFollower not persisting last processed notifications when partition is altered

["kalyan kumar kalvagadda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040846#comment-16040846 ] 

kalyan kumar kalvagadda edited comment on SENTRY-1794 at 6/7/17 1:20 PM:
-------------------------------------------------------------------------

There were checks like these while processing the alter table and alter partition notifications which is wrong. This was causing incorrect behavior.
{noformat}
            } else if ((oldDbName == newDbName) &&
              (oldTableName == newTableName) &&
              (oldLocation == newLocation)) {
{noformat}

Because of such invalid condition check's notification ID is not persisted in cases where alter table and alter partition notifications are not processed.


was (Author: kkalyan):
There were checks like these while processing the alter table and alter partition notifications which is wrong. This was causing incorrect behavior.
{noformat}
            } else if ((oldDbName == newDbName) &&
              (oldTableName == newTableName) &&
              (oldLocation == newLocation)) {
{noformat}

> HMSFollower not persisting last processed notifications when partition is altered
> ---------------------------------------------------------------------------------
>
>                 Key: SENTRY-1794
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1794
>             Project: Sentry
>          Issue Type: Sub-task
>          Components: Sentry
>    Affects Versions: sentry-ha-redesign
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>             Fix For: sentry-ha-redesign
>
>         Attachments: SENTRY-1794.001-sentry-ha-redesign.patch, SENTRY-1794.002-sentry-ha-redesign.patch
>
>
> When there is an HMS notification with alter partition event and no actual change in the location, HMSFollower is not persisting the notification ID.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)