You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/10/19 11:37:29 UTC
[commons-logging] branch master updated: Better internal names
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git
The following commit(s) were added to refs/heads/master by this push:
new 73582f2 Better internal names
73582f2 is described below
commit 73582f2c71414ebcec139b830cc9db246ac901d0
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Oct 19 07:37:24 2023 -0400
Better internal names
Javadoc
---
src/main/java/org/apache/commons/logging/LogFactory.java | 4 ++--
.../org/apache/commons/logging/impl/LogFactoryImpl.java | 14 +++++++-------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/commons/logging/LogFactory.java b/src/main/java/org/apache/commons/logging/LogFactory.java
index d15a025..05f1365 100644
--- a/src/main/java/org/apache/commons/logging/LogFactory.java
+++ b/src/main/java/org/apache/commons/logging/LogFactory.java
@@ -1468,12 +1468,12 @@ public abstract class LogFactory {
* Returns a string that uniquely identifies the specified object, including
* its class.
* <p>
- * The returned string is of form "classname@hashCode", ie is the same as
+ * The returned string is of form "className@hashCode", ie is the same as
* the return value of the Object.toString() method, but works even when
* the specified object's class has overidden the toString method.
*
* @param o may be null.
- * @return a string of form classname@hashCode, or "null" if param o is null.
+ * @return a string of form className@hashCode, or "null" if param o is null.
* @since 1.1
*/
public static String objectId(final Object o) {
diff --git a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
index 8bec91b..c01bc20 100644
--- a/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
+++ b/src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
@@ -322,7 +322,7 @@ public class LogFactoryImpl extends LogFactory {
* Attempts to load the given class, find a suitable constructor,
* and instantiate an instance of Log.
*
- * @param logAdapterClassName classname of the Log implementation
+ * @param logAdapterClassName class name of the Log implementation
* @param logCategory argument to pass to the Log implementation's constructor
* @param affectState {@code true} if this object's state should
* be affected by this method call, {@code false} otherwise.
@@ -597,7 +597,7 @@ public class LogFactoryImpl extends LogFactory {
* a Log implementation specified by the user under the
* property names {@link #LOG_PROPERTY} or {@link #LOG_PROPERTY_OLD}.
*
- * @return classname specified by the user, or {@code null}
+ * @return class name specified by the user, or {@code null}
*/
private String findUserSpecifiedLogClassName() {
if (isDiagnosticsEnabled()) {
@@ -643,7 +643,7 @@ public class LogFactoryImpl extends LogFactory {
}
}
- // Remove any whitespace; it's never valid in a classname so its
+ // Remove any whitespace; it's never valid in a class name so its
// presence just means a user mistake. As we know what they meant,
// we may as well strip the spaces.
if (specifiedClass != null) {
@@ -864,9 +864,9 @@ public class LogFactoryImpl extends LogFactory {
}
/**
- * Return the fully qualified Java classname of the {@link Log} implementation we will be using.
+ * Return the fully qualified Java class name of the {@link Log} implementation we will be using.
*
- * @return the fully qualified Java classname of the {@link Log} implementation we will be using.
+ * @return the fully qualified Java class name of the {@link Log} implementation we will be using.
* @deprecated Never invoked by this class; subclasses should not assume it will be.
*/
@Deprecated
@@ -1244,13 +1244,13 @@ public class LogFactoryImpl extends LogFactory {
* present and available for use. Note that this does <i>not</i>
* affect the future behavior of this class.
*/
- private boolean isLogLibraryAvailable(final String name, final String classname) {
+ private boolean isLogLibraryAvailable(final String name, final String className) {
if (isDiagnosticsEnabled()) {
logDiagnostic("Checking for '" + name + "'.");
}
try {
final Log log = createLogFromClass(
- classname,
+ className,
this.getClass().getName(), // dummy category
false);