[GitHub] [spark] dongjoon-hyun commented on a change in pull request #20430: [SPARK-23263][TEST] CTAS should update stat if autoUpdate statistics is enabled

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #20430: [SPARK-23263][TEST] CTAS should update stat if autoUpdate statistics is enabled
URL: https://github.com/apache/spark/pull/20430#discussion_r283514893
 
 

 ##########
 File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
 ##########
 @@ -1416,4 +1416,21 @@ class StatisticsSuite extends StatisticsCollectionTestBase with TestHiveSingleto
       assert(catalogStats.rowCount.isEmpty)
     }
   }
+
+  test(s"CTAS should update statistics if ${SQLConf.AUTO_SIZE_UPDATE_ENABLED.key} is enabled") {
+    val tableName = "SPARK_23263"
+    Seq(false, true).foreach { updateEnabled =>
+      withSQLConf(SQLConf.AUTO_SIZE_UPDATE_ENABLED.key -> updateEnabled.toString) {
+        withTable(tableName) {
+          sql(s"CREATE TABLE $tableName STORED AS parquet AS SELECT 'a', 'b'")
 
 Review comment:
   This looks affected by `spark.sql.hive.convertMetastoreParquet` automatically. Can we have a test coverage for both cases, `true` and `false`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org