You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/23 01:49:26 UTC
[GitHub] [iceberg] felixYyu commented on a change in pull request #4376: ALL:fixing static analysis warnings
felixYyu commented on a change in pull request #4376:
URL: https://github.com/apache/iceberg/pull/4376#discussion_r832768046
##########
File path: core/src/main/java/org/apache/iceberg/BaseFileScanTask.java
##########
@@ -220,12 +220,13 @@ public Expression residual() {
}
public boolean isAdjacent(SplitScanTask other) {
- return (other != null) &&
- (this.file().equals(other.file())) &&
- (this.offset + this.len == other.offset);
+ return other != null &&
+ this.file().equals(other.file()) &&
+ this.offset + this.len == other.offset;
}
}
+ @SuppressWarnings("MixedMutabilityReturnType")
Review comment:
I will fixing all static analysis warnings with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org