[GitHub] [daffodil] jadams-tresys commented on a change in pull request #674: Work around issue resetting predefined vars

[GitBox <gi...@apache.org>]

jadams-tresys commented on a change in pull request #674:
URL: https://github.com/apache/daffodil/pull/674#discussion_r743018220



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/VariableMap1.scala
##########
@@ -155,6 +155,7 @@ class VariableInstance private (val rd: VariableRuntimeData)
         this.setState(this.priorState)
         this.setValue(this.priorValue)
       }
+      case (VariableDefined, _, _) => // This should only occur for pre-defined variables

Review comment:
       It's possible that the variable is being added twice, not sure.  As I mentioned, I was having trouble recreating the same failure with a test case.
   
   In both of the affected schema projects, they simply reference the dfdl:encoding variable when setting up the dfdl:format that they use for all the files.  It's not being read or changed inside a choice branch, so I'm not sure how this failure is ocurring.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org