You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/22 01:36:16 UTC

[GitHub] [arrow-rs] Jimexist opened a new pull request #591: try out edition 2021

Jimexist opened a new pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591


   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
    <!---
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!---
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!---
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] Jimexist commented on pull request #591: use rust edition 2021

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591#issuecomment-955696226


   with @alamb's help this is finally ready. I'm removing the line to ignore the Miri tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] Jimexist commented on pull request #591: use rust edition 2021

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591#issuecomment-953104973


   > Restarted the integration builds.
   
   for some reason the coverage tests env is still 1.55


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] kszucs commented on pull request #591: use rust edition 2021

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591#issuecomment-952877533


   Restarted the integration builds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #591: use rust edition 2021

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591#issuecomment-955238510


   I am looking into it on https://github.com/apache/arrow-rs/issues/879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] Jimexist merged pull request #591: use rust edition 2021

Posted by GitBox <gi...@apache.org>.
Jimexist merged pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] Jimexist commented on pull request #591: use rust edition 2021

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591#issuecomment-955238464


   Not sure why miri fails


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #591: use rust edition 2021

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #591:
URL: https://github.com/apache/arrow-rs/pull/591#issuecomment-956122459


   🎉 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org