[GitHub] groovy pull request: Fix for GROOVY-6454

[erdi <gi...@git.apache.org>]

GitHub user erdi opened a pull request:

    https://github.com/apache/groovy/pull/299

    Fix for GROOVY-6454

    Add allNames option which allows to include fields/properties/methods with internal names in code generated by Builder, Delegate, EqualsAndHashCode, MapConstructor, ToString and TupleConstructor AST transformations.
    
    I've added tests and updated javadocs and the guide around these new options.
    
    Please let me know if there is anything that needs to be changed, especially in the area of documentation, I'm happy to rework it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erdi/groovy GROOVY-6454

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #299
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request: Fix for GROOVY-6454

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/299


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request: Fix for GROOVY-6454

[erdi <gi...@git.apache.org>]

Github user erdi commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/299#discussion_r57941783
  
    --- Diff: src/spec/test/ClassDesignASTTransformsTest.groovy ---
    @@ -189,14 +189,14 @@ class NumberBooleanBuilder {
         StringBuilder nums = new StringBuilder()
         @Delegate(includeTypes=[AppendFloatSelector], interfaces=false)
         StringBuilder bools = new StringBuilder()
    -    String result() { "${nums.toString()} | ${bools.toString()}" }
    +    String result() { "${nums.toString()} ~ ${bools.toString()}" }
    --- End diff --
    
    This had to be changed because using a pipe here broke the formatting of asciidoc table this snippet was used in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---