You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by kfeagle <gi...@git.apache.org> on 2017/04/17 11:13:23 UTC

[GitHub] incubator-weex pull request #269: Ios demo 0.12 dev

GitHub user kfeagle opened a pull request:

    https://github.com/apache/incubator-weex/pull/269

    Ios demo 0.12 dev

    + [ios] add gcanvas demo
    + [ios] fixbug wxdevtool crash
    + [ios] move pod spec to root directory

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kfeagle/incubator-weex ios-demo-0.12-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #269
    
----
commit eb6b55c25ceda9e3681e195df03a0460787b77e7
Author: \u9f50\u5c71 <su...@163.com>
Date:   2017-04-15T13:56:17Z

    + [example] fix bug demo

commit e72866232abccc74284c480284ec1e83dc6586d1
Author: \u9f50\u5c71 <su...@163.com>
Date:   2017-04-17T11:11:27Z

    + [ios] add gcanvas example & fix wxdevtool crash & move spec to root directory

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #269: + [ios] add gcanvas demo & fixbug wxdevtoo...

Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/269#discussion_r111877751
  
    --- Diff: ios/playground/Podfile ---
    @@ -8,6 +8,8 @@ def common
         pod 'SDWebImage', '3.7.5'
         pod 'SocketRocket', '0.4.2'
         pod 'ATSDK-Weex', '0.0.1'
    +    
    +    pod 'WeexGcanvas', '0.0.1.5'
    --- End diff --
    
    more notes for WeexGcanvas


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #269: + [ios] add gcanvas demo & fixbug wxdevtoo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/269


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #269: + [ios] add gcanvas demo & fixbug wxdevtoo...

Posted by kfeagle <gi...@git.apache.org>.
Github user kfeagle commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/269#discussion_r111880676
  
    --- Diff: ios/playground/Podfile ---
    @@ -8,6 +8,8 @@ def common
         pod 'SDWebImage', '3.7.5'
         pod 'SocketRocket', '0.4.2'
         pod 'ATSDK-Weex', '0.0.1'
    +    
    +    pod 'WeexGcanvas', '0.0.1.5'
    --- End diff --
    
    I add as follow,is it ok?
    # WeexGcanvas is added by Weex Plugin, more info at https://market.dotwe.org/ext/list.htm



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #269: + [ios] add gcanvas demo & fixbug wxdevtoo...

Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/269#discussion_r111878096
  
    --- Diff: WeexSDK.podspec ---
    @@ -0,0 +1,47 @@
    +# coding: utf-8
    +Pod::Spec.new do |s|
    +
    +  s.name         = "WeexSDK"
    +
    +  s.version      = "0.11.0"
    +
    +  s.summary      = "WeexSDK Source ."
    +
    +  s.description  = <<-DESC
    +                   A framework for building Mobile cross-platform UI
    +                   DESC
    +
    +  s.homepage     = "https://github.com/alibaba/weex"
    +  s.license = {
    +    :type => 'Copyright',
    +    :text => <<-LICENSE
    +           Alibaba-INC copyright
    +    LICENSE
    +  }
    +  s.authors      = { "cxfeng1"      => "cxfeng1@gmail.com",
    +                     "boboning"     => "ningli928@163.com",
    +                     "yangshengtao" => "yangshengtao1314@163.com",
    +                     "kfeagle"      => "sunjjbobo@163.com",
    +                     "acton393"     => "zhangxing610321@gmail.com"
    +                   }
    +  s.platform     = :ios
    +  s.ios.deployment_target = '7.0'
    +  s.source =  { :path => '.' }
    +  s.source_files = 'ios/playground/WeexSDK/Sources/**/*.{h,m,mm,c}'
    --- End diff --
    
    there is something wrong with source_files path


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #269: + [ios] add gcanvas demo & fixbug wxdevtoo...

Posted by kfeagle <gi...@git.apache.org>.
Github user kfeagle commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/269#discussion_r111880583
  
    --- Diff: WeexSDK.podspec ---
    @@ -0,0 +1,47 @@
    +# coding: utf-8
    +Pod::Spec.new do |s|
    +
    +  s.name         = "WeexSDK"
    +
    +  s.version      = "0.11.0"
    +
    +  s.summary      = "WeexSDK Source ."
    +
    +  s.description  = <<-DESC
    +                   A framework for building Mobile cross-platform UI
    +                   DESC
    +
    +  s.homepage     = "https://github.com/alibaba/weex"
    +  s.license = {
    +    :type => 'Copyright',
    +    :text => <<-LICENSE
    +           Alibaba-INC copyright
    +    LICENSE
    +  }
    +  s.authors      = { "cxfeng1"      => "cxfeng1@gmail.com",
    +                     "boboning"     => "ningli928@163.com",
    +                     "yangshengtao" => "yangshengtao1314@163.com",
    +                     "kfeagle"      => "sunjjbobo@163.com",
    +                     "acton393"     => "zhangxing610321@gmail.com"
    +                   }
    +  s.platform     = :ios
    +  s.ios.deployment_target = '7.0'
    +  s.source =  { :path => '.' }
    +  s.source_files = 'ios/playground/WeexSDK/Sources/**/*.{h,m,mm,c}'
    --- End diff --
    
    Yes, you're right , thanks for your reminder
    I fix it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---