[GitHub] [calcite] wojustme commented on a change in pull request #2522: [CALCITE-4735] Enhance Aggregate-Materialization, when aggcall of query could be expressed by target's grouping (xurenhe)

[GitBox <gi...@apache.org>]

wojustme commented on a change in pull request #2522:
URL: https://github.com/apache/calcite/pull/2522#discussion_r716215677



##########
File path: core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -1051,6 +1051,59 @@
     sql(mv, query).ok();
   }
 
+  @Test void testAggCallArgExpressedByMvProjs1() {
+    final String mv = ""
+        + "select \"deptno\", \"salary\""
+        + "from \"emps\" group by \"deptno\", \"salary\"";
+    final String query = ""
+        + "select \"deptno\", sum(\"salary\")"
+        + "from \"emps\" group by \"deptno\"";
+    sql(mv, query).ok();

Review comment:
       Yeah, You are right.
   It's incorrect test case.
   I have updated pr, please review it again.
   Thanks a lot.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org