[GitHub] [pulsar] tisonkun commented on a diff in pull request #20052: [improve][cli]Pulsar Dynamic Configuration Feature for Broker-level Configuration

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #20052:
URL: https://github.com/apache/pulsar/pull/20052#discussion_r1199883977


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java:
##########
@@ -69,29 +69,38 @@ private class UpdateConfigurationCmd extends CliCommand {
         @Parameter(names = {"-v", "--value"}, description = "service-configuration value", required = true)
         private String configValue;
 
+        @Parameter(names = {"-s", "--scope"}, description = "cluster or broker address, default is cluster",

Review Comment:
   Shall we use an enum `Scope` instead of String here? Ditto other occurance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org