[GitHub] [arrow] fsaintjacques commented on a change in pull request #7820: ARROW-9068: [C++][Dataset] Simplify partitioning interface

[GitBox <gi...@apache.org>]

fsaintjacques commented on a change in pull request #7820:
URL: https://github.com/apache/arrow/pull/7820#discussion_r461724930



##########
File path: cpp/src/arrow/dataset/partition.h
##########
@@ -59,21 +59,10 @@ class ARROW_DS_EXPORT Partitioning {
   /// \brief The name identifying the kind of partitioning
   virtual std::string type_name() const = 0;
 
-  /// \brief Parse a path segment into a partition expression
-  ///
-  /// \param[in] segment the path segment to parse
-  /// \param[in] i the index of segment within a path
-  /// \return the parsed expression
-  virtual Result<std::shared_ptr<Expression>> Parse(const std::string& segment,
-                                                    int i) const = 0;
-
-  virtual Result<std::string> Format(const Expression& expr, int i) const {
-    // FIXME(bkietz) make this pure virtual
-    return Status::NotImplemented("formatting paths from ", type_name(), " Partitioning");
-  }
-
   /// \brief Parse a path into a partition expression
-  Result<std::shared_ptr<Expression>> Parse(const std::string& path) const;
+  virtual Result<std::shared_ptr<Expression>> Parse(const std::string& segment) const = 0;

Review comment:
       Name the parameter path.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org