You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/02 17:06:36 UTC

[GitHub] Benji81 commented on a change in pull request #4185: Add new visualization for custom X-Y axes

Benji81 commented on a change in pull request #4185: Add new visualization for custom X-Y axes
URL: https://github.com/apache/incubator-superset/pull/4185#discussion_r165701861
 
 

 ##########
 File path: superset/assets/javascripts/explore/stores/controls.jsx
 ##########
 @@ -560,6 +595,59 @@ export const controls = {
     }),
   },
 
+  columns_and_metrics_y: {
+    type: 'SelectControl',
+    multi: true,
+    label: t('Y Axis'),
+    default: [],
+    description: t('Columns or metrics to display'),
+    mapStateToProps: (state) => {
+      let choices = [];
+      if (state.controls && state.datasource) {
 
 Review comment:
    ?  not grouped by

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services