You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/09 20:04:40 UTC

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5228: GEODE-8151: Convert remaining commands to use RedisResponse

jdeppe-pivotal opened a new pull request #5228:
URL: https://github.com/apache/geode/pull/5228


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #5228: GEODE-8151: Convert remaining commands to use RedisResponse

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #5228:
URL: https://github.com/apache/geode/pull/5228#issuecomment-641705498


   The failing test is already reported as GEODE-8176


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] lgtm-com[bot] commented on pull request #5228: GEODE-8151: Convert remaining commands to use RedisResponse

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5228:
URL: https://github.com/apache/geode/pull/5228#issuecomment-641603307


   This pull request **introduces 2 alerts** and **fixes 1** when merging 2823b65548e22ca92d8301572043f2071a3995ff into 6dabaeb519de64d53029d02541d69010d8c2f3f4 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-a41aca6f01c3481538b6512ac6eb833abd767588)
   
   **new alerts:**
   
   * 2 for Boxed variable is never null
   
   **fixed alerts:**
   
   * 1 for Useless null check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] lgtm-com[bot] commented on pull request #5228: GEODE-8151: Convert remaining commands to use RedisResponse

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5228:
URL: https://github.com/apache/geode/pull/5228#issuecomment-641566708


   This pull request **introduces 2 alerts** and **fixes 1** when merging 84071e9048a738e41e524c871cc16f0f70541b93 into 6dabaeb519de64d53029d02541d69010d8c2f3f4 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-e86b7a3b393ef4fbe004717230a2bff31a409af3)
   
   **new alerts:**
   
   * 2 for Boxed variable is never null
   
   **fixed alerts:**
   
   * 1 for Useless null check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] lgtm-com[bot] commented on pull request #5228: GEODE-8151: Convert remaining commands to use RedisResponse

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5228:
URL: https://github.com/apache/geode/pull/5228#issuecomment-641675871


   This pull request **fixes 1 alert** when merging 7642f95a4356a3d3e826168d0df10337ec29bd39 into f65ea452443bcd2d0dac6ef1d2d958b0cb02936f - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-18e4b157fdac1bc99cef7eacc39b0914d1b5b514)
   
   **fixed alerts:**
   
   * 1 for Useless null check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #5228: GEODE-8151: Convert remaining commands to use RedisResponse

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5228:
URL: https://github.com/apache/geode/pull/5228


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org