[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3058: [GOBBLIN-1267] Improvements to Gobblin cli : a command called oneShot to run a single…

[GitBox <gi...@apache.org>]

htran1 commented on a change in pull request #3058:
URL: https://github.com/apache/incubator-gobblin/pull/3058#discussion_r492420961



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/embedded/EmbeddedGobblin.java
##########
@@ -532,7 +539,7 @@ private void dumpJStackOnTimeout(String loc) {
     }
   }
 
-  private Configurable getSysConfig() {
+  public Configurable getSysConfig() {

Review comment:
       Is this public just for testing? We usually put the @VisibleForTesting annotation when access is relaxed just for the purpose of testing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org