You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/09/01 05:34:00 UTC
[jira] [Commented] (LUCENE-9475) Enhance the Gradle build as
necessary after removing Ant support
[ https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188148#comment-17188148 ]
David Smiley commented on LUCENE-9475:
--------------------------------------
[~rmuir] I noticed that yesterday you committed a change to check-source-patterns.groovy to remove a prevention mechanism of the "var". The commit message didn't reference any issue or PR but I see this file migrated to a gradle build file the next day so I suppose this issue is fitting. Please don't make such changes without a JIRA or PR. This check was deliberate on master branch; I recall some conversations that led to it's addition -- https://github.com/apache/lucene-solr/commit/f6f1b4244c40e5665b20a2a8ef9852c6dd827cb2 and especially the rationale in the reported message: "var is not allowed in until we stop development on the 8x code line". We still do development on the 8x code line. When there is no such check on master, it's possible for back-ports to be more painful than they need to be thanks to this rather disruptive Java language feature. The thinking is we wait until 9.0 is released. WDYT? As we get closer to 9.0, I'm caring less about this constraint but I still think it's a good idea.
CC [~erickerickson]
> Enhance the Gradle build as necessary after removing Ant support
> ----------------------------------------------------------------
>
> Key: LUCENE-9475
> URL: https://issues.apache.org/jira/browse/LUCENE-9475
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Affects Versions: master (9.0)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Once the bulk of the Ant build system is removed, stuff will come bubbling up out of the cracks, especially as we try the first 9.0 release which will be Gradle only. Here we list some of the areas we'll have to be aware of. Please add as you see fit. Assigning to myself to track, but I certainly don't want hog all the fun.
> * Remove Maven support and replace with "The Gradle Way" of doing Maven. See LUCENE-9077 (Dawid)
> *
> ** Remove all of dev-tools/maven?
> ** Other dev-tools files no longer used, check if any Gradle build file references and remove if not.
> * -Move Jenkins over to use Gradle only-
> * -Verify reference guide build works under Gradle-
> * Smoke tester
> * Remove anything having to to with Clover (obsolete as of Java 11)
> * -Remove all of {{lucene/tools}} (Ivy, forbiddenapis,...}} -
> * Remove obsolete files in root dirs of lucene and solr (like version.properties, now integrated into gradle)
> * Remove Maven build files (obsolete with Gradle)
> * Hoss's test rollups?
> * Enable javadocs after ant stops being used (LUCENE-9441)
> * fix some relative links in javadocs which contain ant module names (?)
> * dev-tools/scripts/* There are a lot of mentions of ant in the *.py* files, and some in the README.md. This one should probably be its own JIRA since it'll require quite a bit of verification...
> * -Make "the best damn beasting script in the world" work with the Gradle build.- (see LUCENE-9465, LUCENE-9472 for alternatives)
> * Update the release documentation to reflect Gradle (LUCENE-9488)
> * Clean up anything in lucene/tools
> * Clean up Confluence, in particular any page that mentions IDEs. The "How to Contribute" page has several links to various bits and pieces of how to use IDEs, and some mention ant.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org