You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/07/18 13:05:04 UTC
Review Request 50133: LENS-996: Improvements in filters of query list
api
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d5f16b3fc7fffff6c5cfa78c6b9a694c1d
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 20, 2016, 12:03 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java, line 134
> > <https://reviews.apache.org/r/50133/diff/2/?file=1447184#file1447184line134>
> >
> > Removing default values would cause users to always pass the values for these params. they will basically become mandatory params.
It won't become mandatory. http://stackoverflow.com/a/13979349/459384
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/#review142910
-----------------------------------------------------------
On July 19, 2016, 3:15 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50133/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 3:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-996
> https://issues.apache.org/jira/browse/LENS-996
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
> 2. the status filter should be case-insensitive.
> 3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d5f16b3fc7fffff6c5cfa78c6b9a694c1d
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
>
> Diff: https://reviews.apache.org/r/50133/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/#review142910
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 124)
<https://reviews.apache.org/r/50133/#comment208574>
Can you update doc with what date values can be sent?
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 134)
<https://reviews.apache.org/r/50133/#comment208575>
Removing default values would cause users to always pass the values for these params. they will basically become mandatory params.
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 229)
<https://reviews.apache.org/r/50133/#comment208576>
same as above
- Amareshwari Sriramadasu
On July 19, 2016, 9:45 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50133/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 9:45 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-996
> https://issues.apache.org/jira/browse/LENS-996
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
> 2. the status filter should be case-insensitive.
> 3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d5f16b3fc7fffff6c5cfa78c6b9a694c1d
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
>
> Diff: https://reviews.apache.org/r/50133/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/#review143075
-----------------------------------------------------------
Fix it, then Ship it!
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java (line 118)
<https://reviews.apache.org/r/50133/#comment208783>
Might conflict with other patch
- Amareshwari Sriramadasu
On July 21, 2016, 8:43 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50133/
> -----------------------------------------------------------
>
> (Updated July 21, 2016, 8:43 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-996
> https://issues.apache.org/jira/browse/LENS-996
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
> 2. the status filter should be case-insensitive.
> 3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java be0e2c80a6c0081537feaea330192dc85949ad05
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
>
> Diff: https://reviews.apache.org/r/50133/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 29, 2016, 1:36 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java bd19d4ccb68390c1f11341579fbc4e18e15390ab
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 87e128ffb8a17bf42f53a89cc7ccedbdf1ad59c2
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 4f4d4aa60923ab0a50a478347d26238571b692c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fddd3e490ade5eb4a6dce74ba17269c052390367
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 42d9fe0b5470318ae60dc3137113774ad383e743
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e8aa223b76b96d402ea27fd6cc2f43e52ff8199c
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 27, 2016, 5:27 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java bd19d4ccb68390c1f11341579fbc4e18e15390ab
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 87e128ffb8a17bf42f53a89cc7ccedbdf1ad59c2
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 4f4d4aa60923ab0a50a478347d26238571b692c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fddd3e490ade5eb4a6dce74ba17269c052390367
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 42d9fe0b5470318ae60dc3137113774ad383e743
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e8aa223b76b96d402ea27fd6cc2f43e52ff8199c
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 27, 2016, 3:29 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java bd19d4ccb68390c1f11341579fbc4e18e15390ab
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 87e128ffb8a17bf42f53a89cc7ccedbdf1ad59c2
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 4f4d4aa60923ab0a50a478347d26238571b692c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java fddd3e490ade5eb4a6dce74ba17269c052390367
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 42d9fe0b5470318ae60dc3137113774ad383e743
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e8aa223b76b96d402ea27fd6cc2f43e52ff8199c
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 26, 2016, 6:42 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 4f4d4aa60923ab0a50a478347d26238571b692c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 4df2b9bcf22de230e8600930bcd212a6a583c249
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 42d9fe0b5470318ae60dc3137113774ad383e743
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e8aa223b76b96d402ea27fd6cc2f43e52ff8199c
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 25, 2016, 2:55 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 4f4d4aa60923ab0a50a478347d26238571b692c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cf0c168e8e1475f50b36342aa17cd861366d0e3f
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 63a7874c1ac6be1e7d03b9f7456d1276f75786f3
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e8aa223b76b96d402ea27fd6cc2f43e52ff8199c
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 25, 2016, 2:03 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 4f4d4aa60923ab0a50a478347d26238571b692c1
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cf0c168e8e1475f50b36342aa17cd861366d0e3f
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 63a7874c1ac6be1e7d03b9f7456d1276f75786f3
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e8aa223b76b96d402ea27fd6cc2f43e52ff8199c
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 22, 2016, 4:19 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java be0e2c80a6c0081537feaea330192dc85949ad05
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 63a7874c1ac6be1e7d03b9f7456d1276f75786f3
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 6af4225b6d5e8b24d8e2138a74a755034df254c6
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 22, 2016, 4:08 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java af05951393e5e433fd644f20a9c23f7ba3507947
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 0bf2a6687537b36b7987be27ad7be80d1b289f13
lens-client/src/main/java/org/apache/lens/client/LensClient.java d3ec97d6e8ac506952d1aa5e29ad0fb2c8f8f917
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 3cae7175229503bb90abadb7a3048b353b82e36d
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java 7e239f33dccd237c9bee3732931309bb8ea62753
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 1d6125c4eebb99ab3d2e392de69768deaf3b8e44
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java be0e2c80a6c0081537feaea330192dc85949ad05
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 63a7874c1ac6be1e7d03b9f7456d1276f75786f3
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 7679a068161f2d072b1f6e96d0e96109e3bd6bc9
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 6af4225b6d5e8b24d8e2138a74a755034df254c6
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 21, 2016, 7:05 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java be0e2c80a6c0081537feaea330192dc85949ad05
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 21, 2016, 2:13 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java be0e2c80a6c0081537feaea330192dc85949ad05
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50133: LENS-996: Improvements in filters of query
list api
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50133/
-----------------------------------------------------------
(Updated July 19, 2016, 3:15 p.m.)
Review request for lens.
Bugs: LENS-996
https://issues.apache.org/jira/browse/LENS-996
Repository: lens
Description
-------
1. fromDate and endDate should also take human readable dates. DateUtil.resolveDate can be used.
2. the status filter should be case-insensitive.
3. (maybe) the user filter and status filter can take multiple comma separated values and return the union in the result.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d5f16b3fc7fffff6c5cfa78c6b9a694c1d
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
Diff: https://reviews.apache.org/r/50133/diff/
Testing
-------
Thanks,
Rajat Khandelwal