You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benjamin Lerer (Jira)" <ji...@apache.org> on 2021/09/08 12:27:00 UTC

[jira] [Comment Edited] (CASSANDRA-16806) Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation allows it

    [ https://issues.apache.org/jira/browse/CASSANDRA-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411897#comment-17411897 ] 

Benjamin Lerer edited comment on CASSANDRA-16806 at 9/8/21, 12:26 PM:
----------------------------------------------------------------------

{quote}Firing an exception with the message DELETE statements must restrict all PRIMARY KEY columns with equality relations in order to use IF condition on non static columns when it is not supported by the table seems a bit weird to me.{quote}

Sorry, for the confusion. What is not supported on Virtual tables is conditional updates/deletions. Static columns are. We just do not have any virtual tables that use them so far.

[~cnlwsu] We are looking for a second reviewer. Would you have the time for it? The PR is [here|https://github.com/apache/cassandra/pull/1117]


was (Author: blerer):
{quote}Firing an exception with the message DELETE statements must restrict all PRIMARY KEY columns with equality relations in order to use IF condition on non static columns when it is not supported by the table seems a bit weird to me.{quote}

Sorry, for the confusion. What is not supported on Virtual tables is conditional updates/deletions. Static columns are. We just do not have any virtual tables that use them so far.

[~cnlwsu] We are looking for a second reviewer. Would you have the time for it?

> Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation allows it
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16806
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16806
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables
>            Reporter: Benjamin Lerer
>            Assignee: Aleksei Zotov
>            Priority: Normal
>             Fix For: 4.x
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> {{TRUNCATE}} statements are currently not supported by Virtual Tables. For some Virtual Tables it makes sense to allow it.
> It can be done by adding a {{truncate}} method to the {{VirtualTable}} interface and calling that method from {{TruncateStatement}}. The default implementation of the method should be to fire an {{InvalidRequestException}} saying that truncate is not supported on that specific table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org