You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/16 17:32:18 UTC

[GitHub] [camel-kamelets] oscerd opened a new pull request #11: Added AWS2-S3 source kamelet

oscerd opened a new pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11


   Fixes #10 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] oscerd commented on pull request #11: Added AWS2-S3 source kamelet

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11#issuecomment-780469493


   Sure I can do that in a subsequent pr


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] nicolaferraro edited a comment on pull request #11: Added AWS2-S3 source kamelet

Posted by GitBox <gi...@apache.org>.
nicolaferraro edited a comment on pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11#issuecomment-780468865


   ~I think we can stick to one version of the Kamelet here, so I'd remove the existing `aws-s3-source` and rename this. It was copied from an existing example, but there seems there's no reasons to maintain both here, unless they add something from a connector end-user perspective. Wdyt @oscerd ? The Kamelet seems ok.~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] oscerd commented on pull request #11: Added AWS2-S3 source kamelet

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11#issuecomment-780004137


   cc @nicolaferraro 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] nicolaferraro edited a comment on pull request #11: Added AWS2-S3 source kamelet

Posted by GitBox <gi...@apache.org>.
nicolaferraro edited a comment on pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11#issuecomment-780468865


   I think we can stick to one version of the Kamelet here, so I'd remove the existing `aws-s3-source` and rename this. It was copied from an existing example, but there seems there's no reasons to maintain both here, unless they add something from a connector end-user perspective. Wdyt @oscerd ? The Kamelet seems ok.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] oscerd commented on pull request #11: Added AWS2-S3 source kamelet

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11#issuecomment-780513786


   @nicolaferraro updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] nicolaferraro commented on pull request #11: Added AWS2-S3 source kamelet

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11#issuecomment-780468865


   I think we can stick to one version of the Kamelet here, so I'd remove the `aws-s3-source`. It was copied from an existing example, but there seems there's no reasons to maintain both here, unless they add something from a connector end-user perspective. Wdyt @oscerd ? The Kamelet seems ok.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kamelets] nicolaferraro merged pull request #11: Added AWS2-S3 source kamelet

Posted by GitBox <gi...@apache.org>.
nicolaferraro merged pull request #11:
URL: https://github.com/apache/camel-kamelets/pull/11


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org