You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jakob Homan (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 01:18:32 UTC

[jira] [Created] (GIRAPH-62) Provide input format for reading graphs stored as adjacency lists

Provide input format for reading graphs stored as adjacency lists
-----------------------------------------------------------------

                 Key: GIRAPH-62
                 URL: https://issues.apache.org/jira/browse/GIRAPH-62
             Project: Giraph
          Issue Type: New Feature
          Components: lib
            Reporter: Jakob Homan
            Assignee: Jakob Homan


We should provide as many options for getting data in/out of Giraph as possible.  One common format is adjacency lists, with each edge id, its value, and its edges and their values per line.  It would be good to provide inputformats to handle this type of data with minimal effort from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-62) Provide input format for reading graphs stored as adjacency lists

Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136172#comment-13136172 ] 

Avery Ching commented on GIRAPH-62:
-----------------------------------

+1
Jakob, it looks great.  I think it's simpler than using TextVertexInputFormat/TextVertexOutputFormat.  I like the use of mockito for unittesting.  Some minor formatting nits:

Our new agreement is 2 spaces of indentation and 4 for overruns.  The old way is 4 and 8 respectively.  

For src/main/java/org/apache/giraph/graph/Edge.java, I agree to stick with the current formatting until it's all changed (later).

For the new files, you can do either 2 or 4, but I saw a mix in there, please pick one.

Also, saw some 'if(expr)' instead of 'if (expr)'.

Would be great if you can clean this up prior to commit.
                
> Provide input format for reading graphs stored as adjacency lists
> -----------------------------------------------------------------
>
>                 Key: GIRAPH-62
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-62
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-62.patch
>
>
> We should provide as many options for getting data in/out of Giraph as possible.  One common format is adjacency lists, with each edge id, its value, and its edges and their values per line.  It would be good to provide inputformats to handle this type of data with minimal effort from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-62) Provide input format for reading graphs stored as adjacency lists

Posted by "Jakob Homan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated GIRAPH-62:
------------------------------

    Attachment: GIRAPH-62.patch

Patch to create a new vertex reader, which is parameterized on the type of the id, its edge and edge values.  Implementers just have to fill in these methods to ready a new adjacency list encoded as above.  One is provided for lists where the id is a long and the edges and values are doubles, a common format.  I've tested this against a modified pagerankbenchmark (patch coming) and every works as expected.  Introduces mockito for unit testing.
                
> Provide input format for reading graphs stored as adjacency lists
> -----------------------------------------------------------------
>
>                 Key: GIRAPH-62
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-62
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-62.patch
>
>
> We should provide as many options for getting data in/out of Giraph as possible.  One common format is adjacency lists, with each edge id, its value, and its edges and their values per line.  It would be good to provide inputformats to handle this type of data with minimal effort from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-62) Provide input format for reading graphs stored as adjacency lists

Posted by "Jakob Homan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated GIRAPH-62:
------------------------------

    Attachment: GIRAPH-62-2.patch

Updated patch with formatting issues resolved.  Think I got them all.
                
> Provide input format for reading graphs stored as adjacency lists
> -----------------------------------------------------------------
>
>                 Key: GIRAPH-62
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-62
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-62-2.patch, GIRAPH-62.patch
>
>
> We should provide as many options for getting data in/out of Giraph as possible.  One common format is adjacency lists, with each edge id, its value, and its edges and their values per line.  It would be good to provide inputformats to handle this type of data with minimal effort from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-62) Provide input format for reading graphs stored as adjacency lists

Posted by "Jakob Homan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135547#comment-13135547 ] 

Jakob Homan commented on GIRAPH-62:
-----------------------------------

And before someone laughs at the name, it came out to {{LongDoubleDoubleAdjacencyListVertexInputFormat}}, which I know sucks.  I think we should use packaging to better sort the inputformats.  So, perhaps we can store the inputformats for processing graphs stored as adjacency lists in its own package, we can avoid the really long part of the name.  Or, does anyone have a better idea for the name in general?
                
> Provide input format for reading graphs stored as adjacency lists
> -----------------------------------------------------------------
>
>                 Key: GIRAPH-62
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-62
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-62.patch
>
>
> We should provide as many options for getting data in/out of Giraph as possible.  One common format is adjacency lists, with each edge id, its value, and its edges and their values per line.  It would be good to provide inputformats to handle this type of data with minimal effort from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-62) Provide input format for reading graphs stored as adjacency lists

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136280#comment-13136280 ] 

Hudson commented on GIRAPH-62:
------------------------------

Integrated in Giraph-trunk-Commit #17 (See [https://builds.apache.org/job/Giraph-trunk-Commit/17/])
    GIRAPH-62. Provide input format for reading graphs stored as adjacency lists.

jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189402
Files : 
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/pom.xml
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Edge.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/AdjacencyListVertexReader.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/lib/LongDoubleDoubleAdjacencyListVertexInputFormat.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java

                
> Provide input format for reading graphs stored as adjacency lists
> -----------------------------------------------------------------
>
>                 Key: GIRAPH-62
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-62
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.70.0
>
>         Attachments: GIRAPH-62-2.patch, GIRAPH-62.patch
>
>
> We should provide as many options for getting data in/out of Giraph as possible.  One common format is adjacency lists, with each edge id, its value, and its edges and their values per line.  It would be good to provide inputformats to handle this type of data with minimal effort from the user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira