You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/30 22:50:51 UTC
[GitHub] [superset] jinghua-qa opened a new issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
jinghua-qa opened a new issue #15485:
URL: https://github.com/apache/superset/issues/15485
Cascading filters should show layer in filter indicator on native filter panel, now is shown in parallel.
### Expected results
cascading filters should show in parent/ child layer in filter indicator
### Actual results
cascading filters now show in parallel in filter indicator
#### Screenshots
<img width="1792" alt="Screen Shot 2021-06-30 at 1 29 00 PM" src="https://user-images.githubusercontent.com/81597121/124040830-87c65a80-d9ba-11eb-973a-b58483956826.png">
#### How to reproduce the bug
1. create cascade filter
2. go to native filter panel
3. open indicator for cascade filter
4. See error
### Environment
- superset version: master
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
geido commented on issue #15485:
URL: https://github.com/apache/superset/issues/15485#issuecomment-878318098
I am having a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15485:
URL: https://github.com/apache/superset/issues/15485#issuecomment-871793070
It's a recent regression from fixing the forever enlarging popover window 😀, i think. @villebro @kgabryje
Expected behabior
<img width="715" alt="Screen Shot 2021-06-30 at 4 32 56 PM" src="https://user-images.githubusercontent.com/67837651/124043872-d971e380-d9c0-11eb-89ac-208452635e02.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #15485:
URL: https://github.com/apache/superset/issues/15485#issuecomment-931382403
https://github.com/apache/superset/issues/16532 raised a bunch of other concerns about this screen. We decided to change the design of it to improve the user experience. Closing this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed issue #15485:
URL: https://github.com/apache/superset/issues/15485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15485:
URL: https://github.com/apache/superset/issues/15485#issuecomment-871793070
It's a recent regression from fixing the forever enlarging popover window 😀, i think. @villebro @kgabryje
<img width="715" alt="Screen Shot 2021-06-30 at 4 32 56 PM" src="https://user-images.githubusercontent.com/67837651/124043872-d971e380-d9c0-11eb-89ac-208452635e02.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
geido commented on issue #15485:
URL: https://github.com/apache/superset/issues/15485#issuecomment-879106195
We have discussed this with @michael-s-molina and @villebro. This is a conscious choice as you can read in Michael's PR #15390.
We might have an unlimited number of filters. Eventually, the filters won't have enough space available.
Another reason was the input size being different as we move down the hierarchy, which made the UI look poorly designed.
CC @jinghua-qa @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #15485:
URL: https://github.com/apache/superset/issues/15485#issuecomment-884810976
> @geido the changed made in #15390 was not approved or reviewed by product, it was done when I was on PTO. Sorry Diego for the confusion. please do add the indentation back 🙏
@junlincc @geido Can we talk about the motivations for the change and try to approve it before reverting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15485: [native filter] Cascading filters should show layer in filter indicator on native filter panel
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15485:
URL: https://github.com/apache/superset/issues/15485#issuecomment-884580566
@geido the changed made in #15390 was not approved or reviewed by product, it was done when I was on PTO. Sorry Diego for the confusion. please do add the indentation back 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org