[GitHub] [geode] bschuchardt opened pull request #5027: Revert "GEODE-8020: buffer corruption in SSL communications (#4994)"

["bschuchardt (GitHub)" <gi...@apache.org>]

This reverts commit ec8db54ad7f342542762beb8f3e912dff44e3a53.

The fix for GEODE-8020 reduced performance in SSL benchmark tests.
Unfortunately this revert leaves SSL communications broken, but there
are no CI tests that show that this is the case.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/5027 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #5027: Revert "GEODE-8020: buffer corruption in SSL communications (#4994)"

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

> @pivotal-jbarrett yes, that's true. However, there is a system property that folks can use to disable use of pooled direct-buffers in comms: p2p.nodirectBuffers=true, and that will avoid the problem.

Does disabling with the `p2p.nodirectBuffers=true` property result in the same performance issue that this revert corrects?

[ Full content available at: https://github.com/apache/geode/pull/5027 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org