You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2017/06/22 23:58:56 UTC

[2/3] lucene-solr:master: SOLR-9989: remove @SuppressPointFields annotation now that JSON facets work with numeric points+docvalues

SOLR-9989: remove @SuppressPointFields annotation now that JSON facets work with numeric points+docvalues


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/7a9f9b0b
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/7a9f9b0b
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/7a9f9b0b

Branch: refs/heads/master
Commit: 7a9f9b0be02fa31cccca9647bb4b1e74d8569b08
Parents: 49e9b68
Author: Chris Hostetter <ho...@apache.org>
Authored: Thu Jun 22 16:31:56 2017 -0700
Committer: Chris Hostetter <ho...@apache.org>
Committed: Thu Jun 22 16:47:40 2017 -0700

----------------------------------------------------------------------
 .../org/apache/solr/search/facet/TestJsonFacetRefinement.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/7a9f9b0b/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java b/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java
index d91867b..c8bf5ce 100644
--- a/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java
+++ b/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacetRefinement.java
@@ -22,7 +22,6 @@ import java.util.List;
 
 import org.apache.solr.JSONTestUtil;
 import org.apache.solr.SolrTestCaseHS;
-import org.apache.solr.SolrTestCaseJ4;
 import org.apache.solr.client.solrj.SolrClient;
 import org.apache.solr.common.params.ModifiableSolrParams;
 import org.apache.solr.common.util.SimpleOrderedMap;
@@ -33,13 +32,15 @@ import org.junit.Test;
 import org.noggit.JSONParser;
 import org.noggit.ObjectBuilder;
 
-@SolrTestCaseJ4.SuppressPointFields
 public class TestJsonFacetRefinement extends SolrTestCaseHS {
 
   private static SolrInstances servers;  // for distributed testing
 
   @BeforeClass
   public static void beforeTests() throws Exception {
+    // we need DVs on point fields to compute stats & facets
+    if (Boolean.getBoolean(NUMERIC_POINTS_SYSPROP)) System.setProperty(NUMERIC_DOCVALUES_SYSPROP,"true");
+    
     JSONTestUtil.failRepeatedKeys = true;
     initCore("solrconfig-tlog.xml", "schema_latest.xml");
   }