You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Yanghanrui666 (via GitHub)" <gi...@apache.org> on 2026/09/08 07:01:41 UTC
[I] [studio] CI never runs frontend unit tests (vitest) [rocketmq-dashboard]
Yanghanrui666 opened a new issue, #4139:
URL: https://github.com/apache/rocketmq-dashboard/issues/4139
## Problem
The `frontend-build` job in `.github/workflows/ci.yml` runs `npm ci` followed by `npm run build` but **never runs `npm run test`** (vitest). This means the repo's roughly 936 frontend unit tests do not gate any PR or push to `rocketmq-studio`.
A test suite that is not enforced by CI provides no regression protection - a breaking change can be merged without any test failure.
## Current state
```yaml
frontend-build:
name: Frontend Build (Node 20)
steps:
- run: npm ci
- run: npm run build # only type-checks and bundles
```
The `test` script is defined in `web/package.json`:
```json
"test": "vitest run"
```
## Proposed change
Add a `npm run test` step to the `frontend-build` job, after install and before (or after) the build step:
```yaml
- name: Run frontend tests
run: npm run test
```
This is a one-line addition. It depends on #4136 (CI startup fix) being merged first, otherwise the workflow still fails at startup and no jobs run at all.
## Impact
- Every PR that touches frontend code will have its unit tests enforced.
- Flaky tests (maintainer noted two are already flaky) may need attention, but that is a separate issue - ignoring tests entirely is worse.
- The CI runtime will increase by the vitest execution time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio] CI never runs frontend unit tests (vitest) [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4139: [studio] CI never runs frontend unit tests (vitest)
URL: https://github.com/apache/rocketmq-dashboard/issues/4139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio] CI never runs frontend unit tests (vitest) [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4139:
URL: https://github.com/apache/rocketmq-dashboard/issues/4139#issuecomment-6115554080
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio] CI never runs frontend unit tests (vitest) [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4139:
URL: https://github.com/apache/rocketmq-dashboard/issues/4139#issuecomment-5580782867
**Issue Evaluation**
Category: enhancement | Status: **Evaluated**
The enhancement request is valid and important. The repository currently has no CI enforcement of frontend unit tests, which means breaking changes can be merged without test failures.
**Feasibility:** Feasible
- The frontend-new/package.json already defines a test script using react-scripts test
- Adding a test step to CI is straightforward once the base CI workflow is functional
**Scope:**
- Requires PR #4138 (CI startup fix) to be merged first
- Will add one additional step to the frontend-build job
**Compatibility:** No breaking changes
**Note:** The issue mentions vitest with 936 tests, but the actual test framework in frontend-new/package.json is react-scripts test. The principle remains valid regardless of the specific test runner.
**Recommendation:** Merge PR #4138 first, then review and merge PR #4140 to enforce frontend tests in CI.
---
*Automated evaluation by "github-manager-bot"*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org