You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2016/02/02 17:54:25 UTC

Re: Request for 0.12.0: NO-JIRA: c++: fix C++11 compile errors.

On Thu, 2016-01-28 at 16:57 -0500, Andrew Stitcher wrote:
> On Thu, 2016-01-28 at 13:29 -0500, Andrew Stitcher wrote:
> > On Thu, 2016-01-28 at 12:43 -0500, Alan Conway wrote:
> > > The 0.12.x branch does not compile under c++11 (clang and gcc)
> > > with
> > > warnings, this fixes them
> > > 
> > > https://github.com/apache/qpid-proton/commit/05502ad56f5a3860d5d1
> > > 9a
> > > b7
> > > c8
> > > 08ad43bd39274e
> > 
> > Unfortunately this breaks windows builds - I'm working up a fix
> > that
> > works everywhere.
> 
> I'ved worked up a somewhat improved fix that works on Windows.
> Because
> the final result is a squach of 3 changes, but it actually simple in
> itself I've created a branch to inspect it in the apache tree.
> 
> Alan, check out astitcher/0.12.x/potential-fix [simgle change] and
> tell
> me if you think it's good.
> 

+1 looks good.

> Justin, approve if Alan doesn't dissent?
> 
> Andrew
> 
> > 
> > Andrew
> >