You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/23 06:30:56 UTC

Review Request 56971: Changes/Overwrites to Bundles and Coordinators Show as Workflow, Not able to select text from worflow 'Definition' tab

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56971/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-20133
    https://issues.apache.org/jira/browse/AMBARI-20133


Repository: ambari


Description
-------

When saving and/or overwriting coordinator or bundle files, UI appears to have a typo. States that "Workflow" has been saved instead.
Not able to select text from workflow 'Definition' tab.
Dashboard - Select Workflow - Definition Tab - try selecting text. (browser: chrome)


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 17ee0fd 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 86c1dd3 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs aee2072 

Diff: https://reviews.apache.org/r/56971/diff/


Testing
-------

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56971: Changes/Overwrites to Bundles and Coordinators Show as Workflow, Not able to select text from worflow 'Definition' tab

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56971/#review166487
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 23, 2017, 6:30 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56971/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 6:30 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20133
>     https://issues.apache.org/jira/browse/AMBARI-20133
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When saving and/or overwriting coordinator or bundle files, UI appears to have a typo. States that "Workflow" has been saved instead.
> Not able to select text from workflow 'Definition' tab.
> Dashboard - Select Workflow - Definition Tab - try selecting text. (browser: chrome)
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 17ee0fd 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 86c1dd3 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs aee2072 
> 
> Diff: https://reviews.apache.org/r/56971/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56971: Changes/Overwrites to Bundles and Coordinators Show as Workflow, Not able to select text from worflow 'Definition' tab

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56971/#review166489
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 23, 2017, 6:30 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56971/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 6:30 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20133
>     https://issues.apache.org/jira/browse/AMBARI-20133
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When saving and/or overwriting coordinator or bundle files, UI appears to have a typo. States that "Workflow" has been saved instead.
> Not able to select text from workflow 'Definition' tab.
> Dashboard - Select Workflow - Definition Tab - try selecting text. (browser: chrome)
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 17ee0fd 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 86c1dd3 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs aee2072 
> 
> Diff: https://reviews.apache.org/r/56971/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56971: Changes/Overwrites to Bundles and Coordinators Show as Workflow, Not able to select text from worflow 'Definition' tab

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56971/#review166485
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Feb. 23, 2017, 6:30 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56971/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 6:30 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20133
>     https://issues.apache.org/jira/browse/AMBARI-20133
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When saving and/or overwriting coordinator or bundle files, UI appears to have a typo. States that "Workflow" has been saved instead.
> Not able to select text from workflow 'Definition' tab.
> Dashboard - Select Workflow - Definition Tab - try selecting text. (browser: chrome)
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 17ee0fd 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 86c1dd3 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs aee2072 
> 
> Diff: https://reviews.apache.org/r/56971/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>