You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2019/09/03 14:21:00 UTC

[jira] [Resolved] (FLINK-13775) Refactor ExpressionConverter(RexNodeConverter) in blink

     [ https://issues.apache.org/jira/browse/FLINK-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jark Wu resolved FLINK-13775.
-----------------------------
    Resolution: Fixed

[FLINK-13775][table-planner-blink] Refactor ExpressionConverter
 - 1.10.0: b5a0b317ad008e031bbfd16e75ebc2a7eb9ae25f

[FLINK-13775][table-planner-blink] Rename RexNodeConverter to ExpressionConverter
 - 1.10.0: 70f0081264cf01e5c94ddc692e4cb9433c2a6007

[FLINK-13775][table-planner-blink] Correct time field index of window agg
 - 1.10.0: 87ee1a1cb3ea6cf0680a88a9a153aa38762ad0e6


> Refactor ExpressionConverter(RexNodeConverter) in blink
> -------------------------------------------------------
>
>                 Key: FLINK-13775
>                 URL: https://issues.apache.org/jira/browse/FLINK-13775
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner
>            Reporter: Jingsong Lee
>            Assignee: Jingsong Lee
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> For subsequent development, refactor ExpressionConverter in the form of Rules.
> Now the RexNodeConverter has 1000 lines, but these logic can do some better classification.
> Later we will introduce more converter mode, refactoring can let us better maintain and modify.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)