[GitHub] [tvm] leandron commented on a change in pull request #10095: [microTVM] Include standalone_crt dependencies in MLF

[GitBox <gi...@apache.org>]

leandron commented on a change in pull request #10095:
URL: https://github.com/apache/tvm/pull/10095#discussion_r794740072



##########
File path: python/tvm/micro/model_library_format.py
##########
@@ -287,6 +288,9 @@ def reset(tarinfo):
             return tarinfo
 
         tar_f.add(str(source_dir), arcname=".", filter=reset)
+        is_aot = isinstance(mod, executor_factory.AOTExecutorFactoryModule)
+        if is_aot and str(mod.runtime) == "crt":
+            tar_f.add(get_standalone_crt_dir(), arcname="./runtime")

Review comment:
       Can we convert this `./runtime` to be a a variable defined somewhere. So that we can also use it everywhere we need this path identifier, for example, in the `standalone_crt = { ...` definition below around line `327`?

##########
File path: python/tvm/micro/model_library_format.py
##########
@@ -317,6 +321,16 @@ def _export_graph_model_library_format(
         "style": "full-model",
     }
 
+    if is_aot and (str(mod.runtime) == "crt"):
+        standalone_crt = {
+            "short_name": "tvm_standalone_crt",
+            "url": "./runtime",

Review comment:
       here ^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org